Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to current versions of OpenTelemetry SDK and semantic conventions #193

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,14 @@

<properties>
<inceptionYear>2022</inceptionYear>
<opentelemetry.java.version>1.32.0</opentelemetry.java.version>
<opentelemetry.semconv.version>1.25.0</opentelemetry.semconv.version>
<opentelemetry.java.version>1.39.0</opentelemetry.java.version>
<opentelemetry.semconv.version>1.26.0</opentelemetry.semconv.version>
<opentelemetry.java.instrumentation.version>2.5.0</opentelemetry.java.instrumentation.version>
<version.mp.rest.client>3.0.1</version.mp.rest.client>
<version.microprofile-config-api>3.1</version.microprofile-config-api>
<version.awaitility>4.2.1</version.awaitility>
<version.otel.semconv>1.25.0-alpha</version.otel.semconv>
<!-- Telemetry refers only to Semantic Conversion specification, java artifact is only used in TCK -->
<version.otel.semconv-java>1.25.0-alpha</version.otel.semconv-java>
</properties>

<issueManagement>
Expand Down Expand Up @@ -64,16 +66,21 @@
<dependencyManagement>
<dependencies>
<dependency>
<groupId>io.opentelemetry.instrumentation</groupId>
<artifactId>opentelemetry-instrumentation-bom-alpha</artifactId>
<version>${opentelemetry.java.version}-alpha</version>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-bom</artifactId>
<version>${opentelemetry.java.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>io.opentelemetry.instrumentation</groupId>
<artifactId>opentelemetry-instrumentation-annotations</artifactId>
<version>${opentelemetry.java.instrumentation.version}</version>
</dependency>
<dependency>
<groupId>io.opentelemetry.semconv</groupId>
<artifactId>opentelemetry-semconv</artifactId>
<version>${version.otel.semconv}</version>
<version>${version.otel.semconv-java}</version>
</dependency>
</dependencies>
</dependencyManagement>
Expand All @@ -93,6 +100,7 @@
<attributes>
<otel-java-version>${opentelemetry.java.version}</otel-java-version>
<otel-semconv-version>${opentelemetry.semconv.version}</otel-semconv-version>
<otel-instrumentation-version>${opentelemetry.java.instrumentation.version}</otel-instrumentation-version>
</attributes>
</configuration>
</plugin>
Expand Down
2 changes: 1 addition & 1 deletion spec/src/main/asciidoc/opentelemetry-apis.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,4 @@ The above packages have dependencies on the following packages which MUST be sup

=== Tracing Annotations

* https://www.javadoc.io/doc/io.opentelemetry.instrumentation/opentelemetry-instrumentation-annotations/latest/io/opentelemetry/instrumentation/annotations/package-summary.html[io.opentelemetry.instrumentation.annotations] (`WithSpan` and `SpanAttribute` only)
* https://www.javadoc.io/doc/io.opentelemetry.instrumentation/opentelemetry-instrumentation-annotations/{otel-instrumentation-version}/io/opentelemetry/instrumentation/annotations/package-summary.html[io.opentelemetry.instrumentation.annotations] (`WithSpan` and `SpanAttribute` only)
3 changes: 1 addition & 2 deletions spec/src/main/asciidoc/tracing.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,7 @@ Calling the OpenTelemetry API directly MUST work in the same way and yield the s
The https://github.com/open-telemetry/semantic-conventions/blob/v{otel-semconv-version}/docs/http/http-spans.md[Semantic Conventions for HTTP Spans] MUST be followed by any compatible implementation.

NOTE: This is a breaking change from MicroProfile Telemetry 1.1 due to stabilization of HTTP semantic conventions in OpenTelemetry.
Changes to attributes are described in https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/migration-guide.md[HTTP semantic convention stability migration guide].
// Migration guide was not part of 1.24.0 release, so the link is to the main branch.
Changes to attributes are described in https://github.com/open-telemetry/semantic-conventions/blob/v{otel-semconv-version}/docs/http/migration-guide.md[HTTP semantic convention stability migration guide].

Semantic Conventions distinguish several https://github.com/open-telemetry/semantic-conventions/blob/v{otel-semconv-version}/docs/general/attribute-requirement-level.md[Requirement Levels] for attributes.
All Span attributes marked as `Required` and `Conditionally Required` MUST be present in the context of the Span where they are defined.
Expand Down
Loading