Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps after release of 4.16.0 #4974

Merged
merged 27 commits into from
Jan 19, 2024
Merged

Bump deps after release of 4.16.0 #4974

merged 27 commits into from
Jan 19, 2024

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Dec 5, 2023

Related to #4954.

Changelog Entry

Changed

Description

Bump dependencies after release of 4.16.0.

Designs

  • Prettier: Updated code style to match latest Prettier
  • Test: Moved tag and style options tests to HTML to workaround an out-of-memory issue in Jest + Babel
  • Test: Added mime package to Jest transform
  • Test: Using tsd for testing TypeScript definitions, instead of homebrew
    • Temporarily disabled a test around WebChatActivity for testing bot activity, the actual implementation isn't working and our previous test didn't catch it

Specific Changes

  • Run npm run bump
  • Fix all Prettier and ESLint issues
  • Fix markdown-it-for-inline not loading in Webpack
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim added the release Release checklist label Dec 5, 2023
@compulim
Copy link
Contributor Author

compulim commented Dec 5, 2023

It seems bumpbing @babel/traverse to >= 7.23 maybe related to Jest not running properly.

Let's hold on for this and fix other stuff first.

@compulim compulim marked this pull request as draft December 5, 2023 22:23
@compulim compulim marked this pull request as ready for review January 10, 2024 19:14
@compulim compulim merged commit 3d09177 into main Jan 19, 2024
27 of 29 checks passed
@compulim compulim deleted the bump-deps-4.16.0 branch January 19, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants