Skip to content

Commit

Permalink
Update HandledErrorLog.java to improve naming (#566)
Browse files Browse the repository at this point in the history
<!-- Please provide brief information about the PR, what it contains &
its purpose, new behaviors after the change. And let us know here if you
need any help: https://github.com/microsoft/HydraLab/issues/new -->

## Description

<!-- A few words to explain your changes -->

### Linked GitHub issue ID: #  

## Pull Request Checklist
<!-- Put an x in the boxes that apply. This is simply a reminder of what
we are going to look for before merging your code. -->

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Code compiles correctly with all tests are passed.
- [ ] I've read the [contributing
guide](https://github.com/microsoft/HydraLab/blob/main/CONTRIBUTING.md#making-changes-to-the-code)
and followed the recommended practices.
- [ ] [Wikis](https://github.com/microsoft/HydraLab/wiki) or
[README](https://github.com/microsoft/HydraLab/blob/main/README.md) have
been reviewed and added / updated if needed (for bug fixes / features)

### Does this introduce a breaking change?
*If this introduces a breaking change for Hydra Lab users, please
describe the impact and migration path.*

- [ ] Yes
- [ ] No

## How you tested it
*Please make sure the change is tested, you can test it by adding UTs,
do local test and share the screenshots, etc.*


Please check the type of change your PR introduces:
- [ ] Bugfix
- [ ] Feature
- [ ] Technical design
- [ ] Build related changes
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Code style update (formatting, renaming) or Documentation content
changes
- [ ] Other (please describe): 

### Feature UI screenshots or Technical design diagrams
*If this is a relatively large or complex change, kick it off by drawing
the tech design with PlantUML and explaining why you chose the solution
you did and what alternatives you considered, etc...*
  • Loading branch information
hydraxman authored Dec 4, 2023
1 parent 3444781 commit 6216dda
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ public HandledErrorLog createErrorLog(final Thread thread, final Throwable throw
/* Uncaught exception or managed exception. */
errorLog.setFatal(fatal);
if (!fatal) {
errorLog.setType(HandledErrorLog.TYPE);
errorLog.setType(HandledErrorLog.WARNING_TYPE);
}

/* Application launch time. */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public class HandledErrorLog implements Log {
/**
* Log type.
*/
public static final String TYPE = "handledError";
public static final String WARNING_TYPE = "handledError";

/**
* Exception associated to the error.
Expand Down Expand Up @@ -47,6 +47,10 @@ public class HandledErrorLog implements Log {
* The optional user identifier.
*/
private String userId;
/**
* "managedError" -> AppCenter Crash
* "handledError" -> AppCenter Error
*/
private String type = "managedError";

/**
Expand Down

0 comments on commit 6216dda

Please sign in to comment.