Merge pull request #3817 from NikCharlebois/FIXES-#3721

Fixes #3712
microsoft · Oct 19, 2023 · 4e6d1f0 · 4e6d1f0
2 parents a6d17fd + 9be4392
commit 4e6d1f0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,9 @@
 * AADConditionalAccessPolicy
   * Adds support for Authentication Context.
     FIXES [#3813](https://github.com/microsoft/Microsoft365DSC/issues/3813)
+* TeamsComplianceRecordingPolicy
+  * Fixes an issue where the Compliance Application ID wasn't properly retrieved.
+    FIXES [#3712](https://github.com/microsoft/Microsoft365DSC/issues/3712)
 
 # 1.23.1018.1
 

diff --git a/...DSCResources/MSFT_TeamsComplianceRecordingPolicy/MSFT_TeamsComplianceRecordingPolicy.psm1 b/...DSCResources/MSFT_TeamsComplianceRecordingPolicy/MSFT_TeamsComplianceRecordingPolicy.psm1
@@ -78,7 +78,7 @@ function Get-TargetResource
         Write-Verbose -Message "Found an instance with Identity {$Identity}"
         $results = @{
             Identity                                            = $instance.Identity
-            ComplianceRecordingApplications                     = $instance.ComplianceRecordingApplications
+            ComplianceRecordingApplications                     = [Array]$instance.ComplianceRecordingApplications.Id
             Description                                         = $instance.Description
             DisableComplianceRecordingAudioNotificationForCalls = $instance.DisableComplianceRecordingAudioNotificationForCalls
             Enabled                                             = $instance.Enabled

diff --git a/Tests/Unit/Microsoft365DSC/Microsoft365DSC.TeamsComplianceRecordingPolicy.Tests.ps1 b/Tests/Unit/Microsoft365DSC/Microsoft365DSC.TeamsComplianceRecordingPolicy.Tests.ps1
@@ -107,7 +107,7 @@ Describe -Name $Global:DscHelper.DescribeHeader -Fixture {
                         Description                                         = 'FakeStringValue'
                         Enabled                                             = $True
                         DisableComplianceRecordingAudioNotificationForCalls = $True
-                        ComplianceRecordingApplications                     = 'FakeStringValue'
+                        ComplianceRecordingApplications                     = @{Id='FakeStringValue'}
                         Identity                                            = 'FakeStringValue'
 
                     }
@@ -147,7 +147,7 @@ Describe -Name $Global:DscHelper.DescribeHeader -Fixture {
                         Description                                         = 'FakeStringValue'
                         Enabled                                             = $True
                         DisableComplianceRecordingAudioNotificationForCalls = $True
-                        ComplianceRecordingApplications                     = 'FakeStringValue'
+                        ComplianceRecordingApplications                     = @{Id='FakeStringValue'}
                         Identity                                            = 'FakeStringValue'
 
                     }
@@ -175,10 +175,10 @@ Describe -Name $Global:DscHelper.DescribeHeader -Fixture {
                 Mock -CommandName Get-CsTeamsComplianceRecordingPolicy -MockWith {
                     return @{
                         WarnUserOnRemoval                                   = $False
-                        Description                                         = 'FakeStringValueDrift #Drift'
+                        Description                                         = 'FakeStringValueDrift' #Drift
                         Enabled                                             = $False
                         DisableComplianceRecordingAudioNotificationForCalls = $False
-                        ComplianceRecordingApplications                     = 'FakeStringValueDrift #Drift'
+                        ComplianceRecordingApplications                     = @{Id='FakeStringValueDrift'} #Drift
                         Identity                                            = 'FakeStringValue'
                     }
                 }
@@ -212,7 +212,7 @@ Describe -Name $Global:DscHelper.DescribeHeader -Fixture {
                         Description                                         = 'FakeStringValue'
                         Enabled                                             = $True
                         DisableComplianceRecordingAudioNotificationForCalls = $True
-                        ComplianceRecordingApplications                     = 'FakeStringValue'
+                        ComplianceRecordingApplications                     = @{Id='FakeStringValue'}
                         Identity                                            = 'FakeStringValue'
 
                     }