Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Conditional Access disableResilienceDefaults #5586

Merged
merged 11 commits into from
Jan 15, 2025

Conversation

BuehlerSimon
Copy link
Contributor

@BuehlerSimon BuehlerSimon commented Dec 19, 2024

Pull Request (PR) description

Add Conditional Access disableResilienceDefaults

This Pull Request (PR) fixes the following issues

#2458 (partial)

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource parameter descriptions added/updated in the schema.mof.
  • Resource documentation added/updated in README.md.
  • Resource settings.json file contains all required permissions.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • New/changed code adheres to DSC Community Style Guidelines.

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

For next time: You do not have to update the resource documentation. We are generating that automatically.

@ykuijs
Copy link
Member

ykuijs commented Jan 8, 2025

Hi @BuehlerSimon, unit tests are failing. Can you please have a look?

image

@BuehlerSimon BuehlerSimon requested a review from ykuijs January 8, 2025 14:01
@ykuijs ykuijs merged commit eefb68c into microsoft:Dev Jan 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants