AADServicePrincipal - fix AppId assignment

[niwamo]

Pull Request (PR) description

Fixes the assignment of the AppId for the AADServicePrincipal resource. It's currently being set to $appInstance.DisplayName, which does not get instantiated at all in most cases. Even in those cases where it does, DisplayName is the wrong property. The AADServicePrincipal AppId property exists on the AADServicePrincipal object, which is always defined.

This Pull Request (PR) fixes the following issues

• Fixes AADServicePrincipal: AppId is missing from configuration files and cannot be compiled #5549

Task list

• Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
  Entry should say what was changed and how that affects users (if applicable), and
  reference the issue being resolved (if applicable).
• Resource parameter descriptions added/updated in the schema.mof. (NOT APPLICABLE)
• Resource documentation added/updated in README.md. (NOT APPLICABLE)
• Resource settings.json file contains all required permissions. (NOT APPLICABLE)
• Examples appropriately added/updated. (NOT APPLICABLE)
• Unit tests added/updated. (NOT APPLICABLE)
• New/changed code adheres to DSC Community Style Guidelines.

[niwamo]

@niwamo please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

• (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

• (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

[niwamo]

My mistake for not checking the unit tests the first time. The failing test has been patched.

It seems clear that the AADServicePrincipal's AppId property should be equal to the AADServicePrincipal's AppId (rather than its DisplayName). Unsure why the test was configured this way.

[ykuijs]

Just a small comment on the update to the changelog

[niwamo]

@ykuijs @NikCharlebois This is a two-line fix for an issue that breaks the generated M365TenantConfig.ps1 file. Can we get this merged (soon)?

[ykuijs]

Just started the unit tests......if that succeeds successfully, we will merge the PR so it will be included in next weeks release.

[ykuijs]

LGTM