Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #5589 #5617

Merged
merged 9 commits into from
Jan 17, 2025
Merged

Fix for issue #5589 #5617

merged 9 commits into from
Jan 17, 2025

Conversation

dannyKBjj
Copy link
Contributor

@dannyKBjj dannyKBjj commented Jan 9, 2025

Pull Request (PR) description

Over time it seem the number of properties have grown, but the module has not been updated.
Have added support for all properties documented here:
https://github.com/microsoftgraph/microsoft-graph-docs-contrib/blob/main/api-reference/beta/resources/intune-mam-iosmanagedappprotection.md

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource parameter descriptions added/updated in the schema.mof.
  • Resource documentation added/updated in README.md.
  • Resource settings.json file contains all required permissions.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • New/changed code adheres to DSC Community Style Guidelines.

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

@ykuijs
Copy link
Member

ykuijs commented Jan 17, 2025

Hi @dannyKBjj, have you pushed your review changes already? I do not see them yet.

@dannyKBjj
Copy link
Contributor Author

Github desktop seems to think so. I've made some very minor edits and pushed it again.

@ykuijs ykuijs merged commit 3f1df6d into microsoft:Dev Jan 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IntuneAppProtectionPolicyiOS only partially supports App Protection policies
2 participants