-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add caching behaviour to Intune workload #5641
Add caching behaviour to Intune workload #5641
Conversation
674d705
to
8a3922a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few comments.
...ntivirusPolicyWindows10SettingCatalog/MSFT_IntuneAntivirusPolicyWindows10SettingCatalog.psm1
Outdated
Show resolved
Hide resolved
...5DSC/DSCResources/MSFT_IntuneASRRulesPolicyWindows10/MSFT_IntuneASRRulesPolicyWindows10.psm1
Outdated
Show resolved
Hide resolved
...sources/MSFT_IntuneDeviceConfigurationPolicyiOS/MSFT_IntuneDeviceConfigurationPolicyiOS.psm1
Show resolved
Hide resolved
..._IntuneDeviceManagementComplianceSettings/MSFT_IntuneDeviceManagementComplianceSettings.psm1
Outdated
Show resolved
Hide resolved
@ykuijs Will go over the comments. Thank you for the review, it's a huge one 😅 |
@ykuijs Done with the updates to your comments. Hope it's all good now. |
Tests fixed, strange because both should have been hit previously... Anyways, they now work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request (PR) description
This PR adds the caching behaviour of resources to the Intune workload, just as #5629 does with other resources. Where applicable, code was updated to leverage the latest changes in the resource generator and best practices (checking for empty
Id
), updated try/catch blocks etc.This Pull Request (PR) fixes the following issues
None.
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).