Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching behaviour to Intune workload #5641

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

FabienTschanz
Copy link
Contributor

Pull Request (PR) description

This PR adds the caching behaviour of resources to the Intune workload, just as #5629 does with other resources. Where applicable, code was updated to leverage the latest changes in the resource generator and best practices (checking for empty Id), updated try/catch blocks etc.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource parameter descriptions added/updated in the schema.mof.
  • Resource documentation added/updated in README.md.
  • Resource settings.json file contains all required permissions.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • New/changed code adheres to DSC Community Style Guidelines.

@FabienTschanz FabienTschanz force-pushed the feat/intune-resource-caching branch from 674d705 to 8a3922a Compare January 16, 2025 16:48
Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments.

@FabienTschanz
Copy link
Contributor Author

@ykuijs Will go over the comments. Thank you for the review, it's a huge one 😅

@FabienTschanz
Copy link
Contributor Author

@ykuijs Done with the updates to your comments. Hope it's all good now.

@ykuijs
Copy link
Member

ykuijs commented Jan 17, 2025

Unit tests are failing....can you please check?

image

@FabienTschanz
Copy link
Contributor Author

Tests fixed, strange because both should have been hit previously... Anyways, they now work.

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykuijs ykuijs merged commit 919cac7 into microsoft:Dev Jan 17, 2025
2 checks passed
@FabienTschanz FabienTschanz deleted the feat/intune-resource-caching branch January 17, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants