Keep accessors as accessors in emitted anonymous class declarations #60853
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| //// [tests/cases/conformance/declarationEmit/anonymousClassAccessorsDeclarationEmit1.ts] //// | ||
|
|
||
| //// [anonymousClassAccessorsDeclarationEmit1.ts] | ||
| export abstract class Base { | ||
| accessor a = 1; | ||
| } | ||
|
|
||
| export function middle(Super = Base) { | ||
| abstract class Middle extends Super {} | ||
| return Middle; | ||
| } | ||
|
|
||
| class A { | ||
| constructor(...args: any[]) {} | ||
| } | ||
|
|
||
| export function Mixin<T extends typeof A>(Super: T) { | ||
| return class B extends Super { | ||
| get myName(): string { | ||
| return "B"; | ||
| } | ||
| set myName(arg: string) {} | ||
| }; | ||
| } | ||
|
|
||
|
|
||
| //// [anonymousClassAccessorsDeclarationEmit1.js] | ||
| export class Base { | ||
| accessor a = 1; | ||
| } | ||
| export function middle(Super = Base) { | ||
| class Middle extends Super { | ||
| } | ||
| return Middle; | ||
| } | ||
| class A { | ||
| constructor(...args) { } | ||
| } | ||
| export function Mixin(Super) { | ||
| return class B extends Super { | ||
| get myName() { | ||
| return "B"; | ||
| } | ||
| set myName(arg) { } | ||
| }; | ||
| } | ||
|
|
||
|
|
||
| //// [anonymousClassAccessorsDeclarationEmit1.d.ts] | ||
| export declare abstract class Base { | ||
| accessor a: number; | ||
| } | ||
| export declare function middle(Super?: typeof Base): abstract new () => { | ||
| get a(): number; | ||
| set a(arg: number); | ||
| }; | ||
| declare class A { | ||
| constructor(...args: any[]); | ||
| } | ||
| export declare function Mixin<T extends typeof A>(Super: T): { | ||
| new (...args: any[]): { | ||
| get myName(): string; | ||
| set myName(arg: string); | ||
| }; | ||
| } & T; | ||
| export {}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| //// [tests/cases/conformance/declarationEmit/anonymousClassAccessorsDeclarationEmit1.ts] //// | ||
|
|
||
| === anonymousClassAccessorsDeclarationEmit1.ts === | ||
| export abstract class Base { | ||
| >Base : Symbol(Base, Decl(anonymousClassAccessorsDeclarationEmit1.ts, 0, 0)) | ||
|
|
||
| accessor a = 1; | ||
| >a : Symbol(Base.a, Decl(anonymousClassAccessorsDeclarationEmit1.ts, 0, 28)) | ||
| } | ||
|
|
||
| export function middle(Super = Base) { | ||
| >middle : Symbol(middle, Decl(anonymousClassAccessorsDeclarationEmit1.ts, 2, 1)) | ||
| >Super : Symbol(Super, Decl(anonymousClassAccessorsDeclarationEmit1.ts, 4, 23)) | ||
| >Base : Symbol(Base, Decl(anonymousClassAccessorsDeclarationEmit1.ts, 0, 0)) | ||
|
|
||
| abstract class Middle extends Super {} | ||
| >Middle : Symbol(Middle, Decl(anonymousClassAccessorsDeclarationEmit1.ts, 4, 38)) | ||
| >Super : Symbol(Super, Decl(anonymousClassAccessorsDeclarationEmit1.ts, 4, 23)) | ||
|
|
||
| return Middle; | ||
| >Middle : Symbol(Middle, Decl(anonymousClassAccessorsDeclarationEmit1.ts, 4, 38)) | ||
| } | ||
|
|
||
| class A { | ||
| >A : Symbol(A, Decl(anonymousClassAccessorsDeclarationEmit1.ts, 7, 1)) | ||
|
|
||
| constructor(...args: any[]) {} | ||
| >args : Symbol(args, Decl(anonymousClassAccessorsDeclarationEmit1.ts, 10, 14)) | ||
| } | ||
|
|
||
| export function Mixin<T extends typeof A>(Super: T) { | ||
| >Mixin : Symbol(Mixin, Decl(anonymousClassAccessorsDeclarationEmit1.ts, 11, 1)) | ||
| >T : Symbol(T, Decl(anonymousClassAccessorsDeclarationEmit1.ts, 13, 22)) | ||
| >A : Symbol(A, Decl(anonymousClassAccessorsDeclarationEmit1.ts, 7, 1)) | ||
| >Super : Symbol(Super, Decl(anonymousClassAccessorsDeclarationEmit1.ts, 13, 42)) | ||
| >T : Symbol(T, Decl(anonymousClassAccessorsDeclarationEmit1.ts, 13, 22)) | ||
|
|
||
| return class B extends Super { | ||
| >B : Symbol(B, Decl(anonymousClassAccessorsDeclarationEmit1.ts, 14, 8)) | ||
| >Super : Symbol(Super, Decl(anonymousClassAccessorsDeclarationEmit1.ts, 13, 42)) | ||
|
|
||
| get myName(): string { | ||
| >myName : Symbol(B.myName, Decl(anonymousClassAccessorsDeclarationEmit1.ts, 14, 32), Decl(anonymousClassAccessorsDeclarationEmit1.ts, 17, 5)) | ||
|
|
||
| return "B"; | ||
| } | ||
| set myName(arg: string) {} | ||
| >myName : Symbol(B.myName, Decl(anonymousClassAccessorsDeclarationEmit1.ts, 14, 32), Decl(anonymousClassAccessorsDeclarationEmit1.ts, 17, 5)) | ||
| >arg : Symbol(arg, Decl(anonymousClassAccessorsDeclarationEmit1.ts, 18, 15)) | ||
|
|
||
| }; | ||
| } | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| //// [tests/cases/conformance/declarationEmit/anonymousClassAccessorsDeclarationEmit1.ts] //// | ||
|
|
||
| === anonymousClassAccessorsDeclarationEmit1.ts === | ||
| export abstract class Base { | ||
| >Base : Base | ||
| > : ^^^^ | ||
|
|
||
| accessor a = 1; | ||
| >a : number | ||
| > : ^^^^^^ | ||
| >1 : 1 | ||
| > : ^ | ||
| } | ||
|
|
||
| export function middle(Super = Base) { | ||
| >middle : (Super?: typeof Base) => typeof Middle | ||
| > : ^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| >Super : typeof Base | ||
| > : ^^^^^^^^^^^ | ||
| >Base : typeof Base | ||
| > : ^^^^^^^^^^^ | ||
|
|
||
| abstract class Middle extends Super {} | ||
| >Middle : Middle | ||
| > : ^^^^^^ | ||
| >Super : Base | ||
| > : ^^^^ | ||
|
|
||
| return Middle; | ||
| >Middle : typeof Middle | ||
| > : ^^^^^^^^^^^^^ | ||
| } | ||
|
|
||
| class A { | ||
| >A : A | ||
| > : ^ | ||
|
|
||
| constructor(...args: any[]) {} | ||
| >args : any[] | ||
| > : ^^^^^ | ||
| } | ||
|
|
||
| export function Mixin<T extends typeof A>(Super: T) { | ||
| >Mixin : <T extends typeof A>(Super: T) => { new (...args: any[]): B; prototype: Mixin<any>.B; } & T | ||
| > : ^ ^^^^^^^^^ ^^ ^^ ^^^^^^^^^^^^^^^ ^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| >A : typeof A | ||
| > : ^^^^^^^^ | ||
| >Super : T | ||
| > : ^ | ||
|
|
||
| return class B extends Super { | ||
| >class B extends Super { get myName(): string { return "B"; } set myName(arg: string) {} } : { new (...args: any[]): B; prototype: Mixin<any>.B; } & T | ||
| > : ^^^^^^^^^^ ^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| >B : { new (...args: any[]): B; prototype: Mixin<any>.B; } & T | ||
| > : ^^^^^^^^^^ ^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| >Super : A | ||
| > : ^ | ||
|
|
||
| get myName(): string { | ||
| >myName : string | ||
| > : ^^^^^^ | ||
|
|
||
| return "B"; | ||
| >"B" : "B" | ||
| > : ^^^ | ||
| } | ||
| set myName(arg: string) {} | ||
| >myName : string | ||
| > : ^^^^^^ | ||
| >arg : string | ||
| > : ^^^^^^ | ||
|
|
||
| }; | ||
| } | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the accessor case should be handled through
checkFlags. I'm worried that it would require looking carefully at all call sites that handle accessors to cover for this new case - but maybe I'm worried about it prematurely. Anyway, let me know what you think about it ;)