Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolkit: Add missing flock calls. #10804

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Toolkit: Add missing flock calls. #10804

merged 2 commits into from
Oct 25, 2024

Conversation

cwize1
Copy link
Contributor

@cwize1 cwize1 commented Oct 21, 2024

When making changes to partitions or filesystems, it is recommended to take a file lock over the disk block device as this informs the host OS that you are making changes and that it should avoid scanning or changing the device until you are done. While most of the relevant operations are covered, there a few places that are missing the lock. For example, when calling mkfs or resize2fs.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Does this affect the toolchain?

NO

Test Methodology
  • Ran image customizer UTs.

@cwize1
Toolkit: Add missing flock calls.
17c3dc9 
When making changes to partitions or filesystems, it is recommended to
take a file lock over the disk block device as this informs the host OS
that you are making changes and that it should avoid scanning or
changing the device until you are done. While most of the relevant
operations are covered, there a few places that are missing the lock.
For example, when calling `mkfs` or `resize2fs`.
@cwize1 cwize1 requested review from a team as code owners October 21, 2024 21:53
@mfrw mfrw added the 3.0-dev PRs Destined for AzureLinux 3.0 label Oct 22, 2024
@cwize1 cwize1 merged commit e4e12d0 into 3.0-dev Oct 25, 2024
12 checks passed
@cwize1 cwize1 deleted the user/chrisgun/missingFlock branch October 25, 2024 18:56
cwize1 added a commit that referenced this pull request Oct 30, 2024
@cwize1
Image Customizer: Fix partition creation on Ubuntu build hosts.
dd7d533 
The change #10804 (Toolkit: Add missing flock calls) seems to have
caused a problem where on Ubuntu 22.04 build hosts, the partition info
isn't populated quickly enough after partition creation and formatting.
So, the `lsblk` call might return missing information. Adding a
`partprobe` call before the `lsblk` seems to fix the problem.
@cwize1 cwize1 mentioned this pull request Oct 30, 2024
Merged
12 tasks
cwize1 added a commit that referenced this pull request Oct 31, 2024
@cwize1
Image Customizer: Fix partition creation on Ubuntu build hosts. (#10897)
49c865c 
The change #10804 (Toolkit: Add missing flock calls) seems to have caused a problem where on Ubuntu 22.04 build hosts, the partition info isn't populated quickly enough after partition creation and formatting. So, the `lsblk` call might return missing information. Adding a `partprobe` call before the `lsblk` call seems to fix the problem.
@cwize1 cwize1 mentioned this pull request Oct 31, 2024
Merged
12 tasks
cwize1 added a commit that referenced this pull request Oct 31, 2024
@cwize1
Image Customizer: Fix partition creation on Ubuntu build hosts. (#10902)
6836510 
The change #10804 (Toolkit: Add missing flock calls) seems to have caused a problem where on Ubuntu 22.04 build hosts, the partition info isn't populated quickly enough after partition creation and formatting. So, the `lsblk` call might return missing information. Adding a `partprobe` call before the `lsblk` call seems to fix the problem.
cwize1 added a commit that referenced this pull request Nov 1, 2024
@cwize1
Revert "Toolkit: Add missing flock calls. (#10804)"
3853fbd 
This reverts commit e4e12d0.
cwize1 added a commit that referenced this pull request Nov 1, 2024
@cwize1
Revert "Toolkit: Add missing flock calls. (#10804)"
ed71c56 
This reverts commit e4e12d0.
@cwize1 cwize1 mentioned this pull request Nov 1, 2024
Closed
cwize1 added a commit that referenced this pull request Nov 1, 2024
@cwize1
Partial revert of "Toolkit: Add missing flock calls. (#10804)".
561dbac
@cwize1 cwize1 mentioned this pull request Nov 1, 2024
Merged
cwize1 added a commit that referenced this pull request Nov 1, 2024
@cwize1
Partial revert of "Toolkit: Add missing flock calls. (#10804)". (#1…
f52c8e6 
…0917)

Reverting toolkit/imager changes in #10804. Leaving off the changes to image customizer to avoid conflicts with #10902,
nangelastro pushed a commit to nangelastro/azurelinux that referenced this pull request Dec 13, 2024
@cwize1 @nangelastro
Image Customizer: Fix partition creation on Ubuntu build hosts. (micr…
35eb6f6 
…osoft#10897)

The change microsoft#10804 (Toolkit: Add missing flock calls) seems to have caused a problem where on Ubuntu 22.04 build hosts, the partition info isn't populated quickly enough after partition creation and formatting. So, the `lsblk` call might return missing information. Adding a `partprobe` call before the `lsblk` call seems to fix the problem.
durgajagadeesh pushed a commit to durgajagadeesh/azurelinux_djpalli that referenced this pull request Dec 31, 2024
@cwize1 @durgajagadeesh
Toolkit: Add missing flock calls. (microsoft#10804)
3b67cec 
When making changes to partitions or filesystems, it is recommended to take a file lock over the disk block device as this informs the host OS that you are making changes and that it should avoid scanning or changing the device until you are done. While most of the relevant operations are covered, there a few places that are missing the lock. For example, when calling `mkfs` or `resize2fs`.
durgajagadeesh pushed a commit to durgajagadeesh/azurelinux_djpalli that referenced this pull request Dec 31, 2024
@cwize1 @durgajagadeesh
Image Customizer: Fix partition creation on Ubuntu build hosts. (micr…
0594b72 
…osoft#10902)

The change microsoft#10804 (Toolkit: Add missing flock calls) seems to have caused a problem where on Ubuntu 22.04 build hosts, the partition info isn't populated quickly enough after partition creation and formatting. So, the `lsblk` call might return missing information. Adding a `partprobe` call before the `lsblk` call seems to fix the problem.
durgajagadeesh pushed a commit to durgajagadeesh/azurelinux_djpalli that referenced this pull request Dec 31, 2024
@cwize1 @durgajagadeesh
Partial revert of "Toolkit: Add missing flock calls. (microsoft#10804…
a464171 
…)". (microsoft#10917)

Reverting toolkit/imager changes in microsoft#10804. Leaving off the changes to image customizer to avoid conflicts with microsoft#10902,
JocelynBerrendonner pushed a commit to JocelynBerrendonner/azurelinux that referenced this pull request Jan 23, 2025
@cwize1 @JocelynBerrendonner
Toolkit: Add missing flock calls. (microsoft#10804)
8eaaf62 
When making changes to partitions or filesystems, it is recommended to take a file lock over the disk block device as this informs the host OS that you are making changes and that it should avoid scanning or changing the device until you are done. While most of the relevant operations are covered, there a few places that are missing the lock. For example, when calling `mkfs` or `resize2fs`.
JocelynBerrendonner pushed a commit to JocelynBerrendonner/azurelinux that referenced this pull request Jan 23, 2025
@cwize1 @JocelynBerrendonner
Image Customizer: Fix partition creation on Ubuntu build hosts. (micr…
711d59d 
…osoft#10902)

The change microsoft#10804 (Toolkit: Add missing flock calls) seems to have caused a problem where on Ubuntu 22.04 build hosts, the partition info isn't populated quickly enough after partition creation and formatting. So, the `lsblk` call might return missing information. Adding a `partprobe` call before the `lsblk` call seems to fix the problem.
JocelynBerrendonner pushed a commit to JocelynBerrendonner/azurelinux that referenced this pull request Jan 23, 2025
@cwize1 @JocelynBerrendonner
Partial revert of "Toolkit: Add missing flock calls. (microsoft#10804…
6d808b1 
…)". (microsoft#10917)

Reverting toolkit/imager changes in microsoft#10804. Leaving off the changes to image customizer to avoid conflicts with microsoft#10902,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcilvaney dmcilvaney dmcilvaney approved these changes

@PawelWMS PawelWMS PawelWMS approved these changes

@romoh romoh romoh approved these changes

Assignees
No one assigned
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cwize1 @romoh @dmcilvaney @PawelWMS @mfrw