-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade: python-cmd2 to version 2.4.2 #11671
base: 3.0-dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me. I have left a minor comment. Please look into it.
Release: 4%{?dist} | ||
Name: python-%{pypi_name} | ||
Version: 2.4.2 | ||
Release: 1%{?dist} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please increase the release to 9(+1 from changelog). This is what your team is following.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added requested changes. Requesting team for review
|
||
%changelog | ||
* Fri Oct 15 2021 Pawel Winogrodzki <[email protected]> - 0.9.16-4 | ||
- Initial CBL-Mariner import from Fedora 32 (license: MIT). | ||
* Wed Dec 20 2024 Sumit Jena <[email protected]> - 2.4.2-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to bump up the release number in change log to 2.4.2-9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added requested changes. Pardon me for missing out on change logs earlier. Requesting for review.
9acfaba
to
84d6cc0
Compare
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
What does the PR accomplish, why was it needed?
This PR is to upgrade the package python-cmd2 to version 2.4.2
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology