Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: python-cmd2 to version 2.4.2 #11671

Open
wants to merge 3 commits into
base: 3.0-dev
Choose a base branch
from

Conversation

SumitJenaHCL
Copy link

@SumitJenaHCL SumitJenaHCL commented Dec 23, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
This PR is to upgrade the package python-cmd2 to version 2.4.2

Change Log
  • SPECS-EXTENDED/python-cmd2/python-cmd2.signatures.json
  • SPECS-EXTENDED/python-cmd2/python-cmd2.spec
  • cgmanifest.json
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Local Build

@SumitJenaHCL SumitJenaHCL requested review from a team as code owners December 23, 2024 09:12
@SumitJenaHCL SumitJenaHCL marked this pull request as draft January 2, 2025 10:38
@SumitJenaHCL SumitJenaHCL marked this pull request as ready for review January 3, 2025 05:20
Copy link
Contributor

@suresh-thelkar suresh-thelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. I have left a minor comment. Please look into it.

Release: 4%{?dist}
Name: python-%{pypi_name}
Version: 2.4.2
Release: 1%{?dist}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increase the release to 9(+1 from changelog). This is what your team is following.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added requested changes. Requesting team for review

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Jan 12, 2025

%changelog
* Fri Oct 15 2021 Pawel Winogrodzki <[email protected]> - 0.9.16-4
- Initial CBL-Mariner import from Fedora 32 (license: MIT).
* Wed Dec 20 2024 Sumit Jena <[email protected]> - 2.4.2-1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to bump up the release number in change log to 2.4.2-9

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added requested changes. Pardon me for missing out on change logs earlier. Requesting for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants