Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CVE-2025-21613 and CVE-2025-21614 for packer #11890

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Fix CVE-2025-21613 and CVE-2025-21614 for packer #11890

merged 3 commits into from
Jan 14, 2025
+178 −377

Conversation

realsdx
Copy link
Contributor

@realsdx realsdx commented Jan 13, 2025 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

What does the PR accomplish, why was it needed?

Change Log
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging fasttrack/2.0 PRs Destined for AzureLinux 2.0 labels Jan 13, 2025
@realsdx realsdx marked this pull request as ready for review January 13, 2025 19:53
@realsdx realsdx requested a review from a team as a code owner January 13, 2025 19:53
rikenm1
rikenm1 requested changes Jan 13, 2025
View reviewed changes
SPECS/packer/packer.spec
Patch3: CVE-2024-6104.patch
Patch4: CVE-2024-24786.patch
Patch5: CVE-2024-45337.patch
Patch6: CVE-2024-45338.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for the removal of these patches?

Copy link
Contributor Author

@realsdx realsdx Jan 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these are fixed by version upgrade for the vendors. For CVE-2025-21613 and CVE-2025-21614 version upgrade of the dependencies are required.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok makes sense.

@realsdx realsdx requested a review from rikenm1 January 14, 2025 16:42
rikenm1
rikenm1 approved these changes Jan 14, 2025
View reviewed changes
SPECS/packer/packer.spec
Patch3: CVE-2024-6104.patch
Patch4: CVE-2024-24786.patch
Patch5: CVE-2024-45337.patch
Patch6: CVE-2024-45338.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok makes sense.

@jslobodzian jslobodzian merged commit 966a0f4 into fasttrack/2.0 Jan 14, 2025
6 checks passed
@jslobodzian jslobodzian deleted the sudipta/packer-cve-2025-21613-ft2 branch January 14, 2025 19:51
CBL-Mariner-Bot pushed a commit that referenced this pull request Jan 14, 2025
@realsdx @CBL-Mariner-Bot
Fix CVE-2025-21613 and CVE-2025-21614 for packer (#11890)
e0850cf 
Co-authored-by: jslobodzian <[email protected]>
(cherry picked from commit 966a0f4)
@CBL-Mariner-Bot CBL-Mariner-Bot mentioned this pull request Jan 14, 2025
Merged
@CBL-Mariner-Bot
Copy link
Collaborator

Auto cherry-pick results:

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=711240&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikenm1 rikenm1 rikenm1 approved these changes

@jslobodzian jslobodzian jslobodzian approved these changes

Assignees
No one assigned
Labels
fasttrack/2.0 PRs Destined for AzureLinux 2.0 Packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@realsdx @CBL-Mariner-Bot @jslobodzian @rikenm1