Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang: bump version 1.22.7 -> 1.23.4 #11901

Closed
wants to merge 4 commits into from

Conversation

mfrw
Copy link
Member

@mfrw mfrw commented Jan 14, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

  • golang: bump version 1.22.7 -> 1.23.4
Change Log
  • golang: bump version 1.22.7 -> 1.23.4
Does this affect the toolchain?

YES/NO

Associated issues
  • NA
Links to CVEs
  • NA
Test Methodology
  • Pipeline build id: [validating]

CBL-Mariner-Bot and others added 3 commits January 14, 2025 19:18
Signed-off-by: Muhammad Falak R Wani <[email protected]>
Signed-off-by: Muhammad Falak R Wani <[email protected]>
@mfrw mfrw requested a review from a team as a code owner January 14, 2025 13:56
@mfrw mfrw changed the title golang: golang: bump version 1.22.7 -> 1.23.4 golang: bump version 1.22.7 -> 1.23.4 Jan 14, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED fasttrack/2.0 PRs Destined for AzureLinux 2.0 labels Jan 14, 2025
SPECS/golang/golang.spec Outdated Show resolved Hide resolved
@rikenm1
Copy link
Contributor

rikenm1 commented Jan 14, 2025

Falak, there seems to bea failure in the vitess package build.

@@ -14,7 +14,7 @@
%define __find_requires %{nil}
Summary: Go
Name: golang
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we only needed to upgrade msft-golang.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure:

PTAL whenever you get a chance.

@rikenm1 rikenm1 closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fasttrack/2.0 PRs Destined for AzureLinux 2.0 Packaging specs-extended PR to fix SPECS-EXTENDED
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants