Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go from 1.20 to 1.21 in .github/workflows/quickstart_2.0.yml #11927

Open
wants to merge 6 commits into
base: 3.0-dev
Choose a base branch
from

Conversation

osamaesmailmsft
Copy link
Contributor

@osamaesmailmsft osamaesmailmsft commented Jan 15, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
The workflow Verify Quickstart 2.0 has been failing for an extended period of time, and this change fixes the simple issues.

Change Log
  • Updated the prerequisites in .github/workflows/quickstart_2.0.yml to match those in 2.0's Quickstart README
Does this affect the toolchain?

NO

Test Methodology

@microsoft-github-policy-service microsoft-github-policy-service bot added the 3.0-dev PRs Destined for AzureLinux 3.0 label Jan 15, 2025
@osamaesmailmsft osamaesmailmsft marked this pull request as ready for review January 15, 2025 21:16
@osamaesmailmsft osamaesmailmsft requested a review from a team as a code owner January 15, 2025 21:16
@@ -24,6 +24,7 @@ BuildRequires: asciidoc
BuildRequires: coreutils
BuildRequires: msopenjdk-17
BuildRequires: make
BuildRequires: python3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@osamaesmailmsft please revert this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants