Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurelinux-sysinfo: remove check for cloud-init in script #11930

Closed

Conversation

amritakohli
Copy link
Contributor

@amritakohli amritakohli commented Jan 15, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Not all images may use cloud-init / have a cloud-init log. In that case, we don't want the service to fail and simply leave the cloud-init portion of the output empty.

Removing check=True from the cloud-init analyze command so that it doesn't fail if cloud-init is not present.

Also formatted the python file.

Change Log
  • Remove check for cloud-init analyze
  • Formatting
  • Updated signatures
Does this affect the toolchain?

NO

Test Methodology

@amritakohli amritakohli requested review from a team as code owners January 15, 2025 22:03
@amritakohli amritakohli changed the base branch from 3.0 to 3.0-dev January 15, 2025 22:03
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED Tools Schema Changes to image configurations 3.0-dev PRs Destined for AzureLinux 3.0 labels Jan 15, 2025
@amritakohli amritakohli changed the title Amritakohli cloudinit azurelinux-sysinfo: remove check for cloud-init in script Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging Schema Changes to image configurations specs-extended PR to fix SPECS-EXTENDED Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant