-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typo spelling grammar #1292
base: 1.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it, this made my day a lot better! One request, though: please open the PR on top of the 1.0-dev
branch. That's where we take in all changes.
@@ -68,7 +68,7 @@ func main() { | |||
} | |||
|
|||
// addUnresolvedPackage adds an unresolved node to the graph representing the | |||
// packged described in the PackgetVer structure. Returns an error if the node | |||
// packaged described in the PackgetVer structure. Returns an error if the node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case we probably meant "package".
ok sir, thanks @PawelWMS i will do it, but when i pull on |
First grab the latest |
Thank you for your suggestions. The documentation changes will be accepted in an upcoming PR. The remaining code changes need to be rebased to main |
okay thanks sir @jslobodzian 💯 |
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
./cgmanifest.json
,./toolkit/tools/cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./SPECS/LICENSES-AND-NOTICES/data/licenses.json
,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md
,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passdescription
fix typo spelling grammar and replace to correct words with reference from merriam webster
Does this affect the toolchain?
NO
Test Methodology
testing not include because just replace the typo