Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo spelling grammar #1292

Open
wants to merge 1 commit into
base: 1.0
Choose a base branch
from
Open

fix: typo spelling grammar #1292

wants to merge 1 commit into from

Conversation

slowy07
Copy link

@slowy07 slowy07 commented Aug 18, 2021

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

description

fix typo spelling grammar and replace to correct words with reference from merriam webster

Does this affect the toolchain?

NO

Test Methodology

testing not include because just replace the typo

Copy link
Contributor

@PawelWMS PawelWMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it, this made my day a lot better! One request, though: please open the PR on top of the 1.0-dev branch. That's where we take in all changes.

@@ -68,7 +68,7 @@ func main() {
}

// addUnresolvedPackage adds an unresolved node to the graph representing the
// packged described in the PackgetVer structure. Returns an error if the node
// packaged described in the PackgetVer structure. Returns an error if the node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case we probably meant "package".

@slowy07
Copy link
Author

slowy07 commented Aug 18, 2021

ok sir, thanks @PawelWMS i will do it, but when i pull on 1.0 dev i get many changes from few contributors on my pull request, how i fix that?, or i just pull my changes ?

@slowy07 slowy07 mentioned this pull request Aug 18, 2021
11 tasks
@PawelWMS
Copy link
Contributor

ok sir, thanks @PawelWMS Pawel Winogrodzki FTE i will do it, but when i pull on 1.0 dev i get many changes from few contributors on my pull request, how i fix that?, or i just pull my changes ?

First grab the latest 1.0-dev. Since you have very few commits here, I think the easiest way would be to cherry-pick them onto a new branch created off of that clean 1.0-dev. You can also try rebasing and selecting only your commits.

@slowy07 slowy07 mentioned this pull request Aug 19, 2021
11 tasks
@jslobodzian
Copy link
Contributor

Thank you for your suggestions. The documentation changes will be accepted in an upcoming PR. The remaining code changes need to be rebased to main

@slowy07
Copy link
Author

slowy07 commented Jun 10, 2022

okay thanks sir @jslobodzian 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants