Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Add Cassandra-CPP-Driver re-based off main #2015

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

andrew-lee-1089
Copy link

@andrew-lee-1089 andrew-lee-1089 commented Jan 26, 2022

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Adds the cassandra-cpp-driver RPM, which is already present in Mariner 1.0, to Mariner 2.0.
Needed for some A40 products as containers to build in Mariner 2.0

Change Log
  • Adds the cassandra-cpp-driver RPM, which is already present in Mariner 1.0, to Mariner 2.0
Does this affect the toolchain?

NO

Test Methodology
  • I have manually built the RPM locally

@christopherco christopherco requested a review from a team January 29, 2022 02:53
Copy link
Contributor

@christopherco christopherco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this package! Please do fill out the PR template for this change.

@PawelWMS PawelWMS changed the title Add Cassandra-CPP-Driver re-based off main [main] Add Cassandra-CPP-Driver re-based off main Feb 1, 2022
@andrew-lee-1089
Copy link
Author

Sorry for the delay - I'd like to get this merged.
I cant' for the life of me understand why spec linting is failing.

@chalamalasetty
Copy link
Contributor

Hi Andrew, Thank you for adding this. Can you confirm this Cassandra-CPP-Driver package has no conflicts with files from Cassandra rpm? As a quick test you can install these two rpms on Mariner image.

@PawelWMS PawelWMS requested a review from a team as a code owner December 12, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants