Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote python-requests-mock to SPECS #3309

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Promote python-requests-mock to SPECS #3309

wants to merge 3 commits into from

Conversation

Sumynwa
Copy link
Contributor

@Sumynwa Sumynwa commented Jul 6, 2022 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

Promote requests-mock to meet runtime dependency for package cassandra-medusa

Change Log
  • move from SPECS-EXTENDED to SPECS
  • update specs from Fedora 36
  • remove conditional builds on 'python2'
  • bump version to 1.8.0
  • add as runtime dependency for cassandra-medusa
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Local Build

Sumynwa added 2 commits July 6, 2022 20:15
@Sumynwa
Moving python-requests-mock SPEC from SPECS-EXTENDED to SPECS directory.
b80fb8f
@Sumynwa
(a) Moving python-requests-mock from SPECS-EXTENDED to SPECS directory.
df309b8 
(b) Updating SPEC file from Fedora 36, removing python2 conditional builds.
(c) Bumping version to 1.8.0.
(d) Adding as run dependency for package cassandra medusa.
@Sumynwa Sumynwa requested a review from a team as a code owner July 6, 2022 15:01
@ghost ghost added the main PR Destined for main label Jul 6, 2022
@Sumynwa Sumynwa changed the title Sumsharma/python requests mock Moving python-requests-mock to SPECS directory. Bumping version to 1.8.0 Jul 6, 2022
@Sumynwa
(a) Remove unneeded patch
fe1e4b5 
(b) Fix check section
(c) Changelog corrections
@Sumynwa Sumynwa changed the title Moving python-requests-mock to SPECS directory. Bumping version to 1.8.0 Promote python-requests-mock to SPECS Sep 15, 2022
@Sumynwa Sumynwa marked this pull request as draft May 22, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviacrain oliviacrain oliviacrain approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
main PR Destined for main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sumynwa @oliviacrain