Add package python-parallel-ssh #3312
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
oliviacrain
suggested changes
Jul 7, 2022
Comment on lines
28
to
33
| %package -n python3-%{srcname} | ||
| Summary: %{summary} | ||
| BuildRequires: python3-devel | ||
| BuildRequires: python3-setuptools | ||
| BuildRequires: python3-Cython | ||
| %{?python_provide:%python_provide python3-%{srcname}} |
There was a problem hiding this comment.
Fedora's Python packages use automatic dependency generators, which we don't have. Please add runtime requirements for python3 and the other packages required by this package.
|
|
||
| %description -n python3-%{srcname} %{_description} | ||
|
|
||
| Python 3 version. |
There was a problem hiding this comment.
This line is redundant- we only ship the python3 version of this package.
| %global srcname parallel-ssh | ||
|
|
||
| Name: python-%{srcname} | ||
| Version: 1.9.1 |
There was a problem hiding this comment.
This is a fairly old version. Can we upgrade to a newer version?
There was a problem hiding this comment.
Bumped version to 2.10.0
|
|
||
| %changelog | ||
| * Wed Jun 22 2022 Sumedh Sharma <[email protected]> - 1.9.1-10 | ||
| - Initial CBL-Mariner import from fedora 35(License: LGPLv2) |
There was a problem hiding this comment.
This line should have the license of the spec file, not the license of the package.
Suggested change
| - Initial CBL-Mariner import from fedora 35(License: LGPLv2) | |
| - Initial CBL-Mariner import from Fedora 35 (License: MIT) |
(a) Initial import from fedora 35. (b) Adding as run dependency for cassandra medusa. (c) License Verified.
(b) List runtime dependencies instead of incorrectly using fedora dependency generator. (c) Fix 'check' section. (d) SPEC cleanup.
Sumynwa
force-pushed
the
python-parallel-ssh
branch
from
38ea82e to
fd88064
Compare
oliviacrain
approved these changes
Sep 12, 2022
Sumynwa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/tools/cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Add parallel-ssh to meet runtime dependency for package cassandra-medusa
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology