Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote libtomcrypt to SPECS #3380

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Promote libtomcrypt to SPECS #3380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fba56b3
Moving libtomcrypt from SPECS-EXTENDED to SPECS folder. Build depende…
Sumynwa Jul 15, 2022
a21dba7
(a) Bump release version
Sumynwa Jul 25, 2022
dce1a0f
Lint libtomcrypt spec file
Sumynwa Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...D/libtomcrypt/libtomcrypt.signatures.json → ...S/libtomcrypt/libtomcrypt.signatures.json
View file
Open in desktop
File renamed without changes.
7 changes: 5 additions & 2 deletions SPECS-EXTENDED/libtomcrypt/libtomcrypt.spec → SPECS/libtomcrypt/libtomcrypt.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Summary: A comprehensive, portable cryptographic toolkit
Name: libtomcrypt
Version: 1.18.2
Release: 8%{?dist}
Release: 9%{?dist}
Copy link
Contributor

@PawelWMS PawelWMS Sep 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this just now - it looks like there's a BuildRequires: libtommath-devel, which is an extended package. I'd double-check that this one builds in the presence of ONLY core packages. If not, you will need to move the dependencies from extended specs as well.

Short explanation:

Core packages cannot have any external dependencies and so must build by only depending on each other. Extended packages are allowed to use core and extended, so each extended -> core migration must take into account the extended-only dependencies.

License: Public Domain OR WTFPL
Vendor: Microsoft Corporation
Distribution: Mariner
Expand Down Expand Up @@ -33,7 +33,7 @@ developing applications that use %{name}.
%setup -q

%build
%set_build_flags
%{set_build_flags}
export PREFIX="%{_prefix}"
export INCPATH="%{_includedir}"
export LIBPATH="%{_libdir}"
Expand Down Expand Up @@ -70,6 +70,9 @@ sed -i \
%{_libdir}/pkgconfig/*.pc

%changelog
* Mon Jul 25 2022 Sumedh Sharma <[email protected]> - 1.18.2-9
- Move to SPECS folder.

* Fri Feb 04 2022 Pawel Winogrodzki <[email protected]> - 1.18.2-8
- Removing docs to drop dependency on 'ghostscript'.
- License verified.
Expand Down