-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote libtommath to SPECS #3381
base: main
Are you sure you want to change the base?
Conversation
…cy for package libtomcrypt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bump the release number of this package. We do this to ensure users with both the base and extended repos installed will pull the base repo version of the package.
That'll also allow me to actually comment on the file itself, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar comments as for #3374:
Specs from SPECS-EXTENDED
rarely can be simply moved into SPECS
without additional work as they have a lower bar in terms of test, spec structure, linting, etc.
Please make sure to now:
- Lint the spec.
- Make sure the ptests (inside the
%check
section) run successfully. - Remove all references to other distros (if any). In most cases we tend to keep the parts of the spec, which were enabled for Fedora and remove the other ones.
- Remove the GPG keyring and signatures - we rely on the
signatures.json
files. - Make sure all automated PR checks pass (hard to miss, you probably won't be able to merge before the required ones are resolved).
(b) Spec linting.
Bumped the release version. |
Thank you for doing that! I think we still need to lint the spec a bit more because I see that the |
Linted spec file using steps mentioned in https://dev.azure.com/mariner-org/mariner/_wiki/wikis/mariner.wiki/125/Introduction-to-SPEC-Files?anchor=spec-linter Changes verified via Buddy Build: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=239707&view=results |
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/tools/cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./SPECS/LICENSES-AND-NOTICES/data/licenses.json
,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md
,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
Promote libtommath to meet build dependency for package libtomcrypt.
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology