Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolkit: added RPMs snapshots. #3734

Merged
merged 19 commits into from
Sep 16, 2022

Conversation

PawelWMS
Copy link
Contributor

@PawelWMS PawelWMS commented Sep 10, 2022

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Extending the toolkit archive to contain a snapshot of all RPMs, which could have been built at the time the archive was created. This is part of a larger change to enable building specs with an explicitly defined set of RPMs instead of the latest ones available on PMC.

Change Log
  • Extended toolkit archive to contain an RPMs snapshot.
Does this affect the toolchain?

No.

Test Methodology
  • Local toolkit build.
  • Pipeline toolkit build: 236165

@PawelWMS PawelWMS requested a review from a team as a code owner September 10, 2022 01:10
@ghost ghost added Tools main PR Destined for main labels Sep 10, 2022
toolkit/scripts/toolkit.mk Show resolved Hide resolved
toolkit/scripts/toolkit.mk Show resolved Hide resolved
toolkit/scripts/toolkit.mk Show resolved Hide resolved
@dmcilvaney
Copy link
Contributor

No major issues that I see, I think this should work as intended.

@PawelWMS PawelWMS merged commit c4a4c00 into microsoft:main Sep 16, 2022
@PawelWMS PawelWMS deleted the pawelwi/adding_rpms_snapshot branch September 16, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants