Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor toolkit/tools/internal -> toolkit/tools/pkg #5185

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mfrw
Copy link
Member

@mfrw mfrw commented Mar 30, 2023

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

This PR is broken down in 3 logical commits:

  • Move all the packages form the internal directory -> pkg directory
  • Update all imports for go files
  • Update tools.mk to reflect the above change
git mv toolkit/tools/internal/* toolkit/tools/pkg/
fd | sad 'toolkit/tools/internal' 'toolkit/tools/pkg' --commit
# Manual edit of toolkit/scripts/tools.mk to rename `go_internal_files` -> `go_pkg_files`

Reference:

Change Log
  • toolkit: mv internal/* -> pkg/*
  • toolkit: pkg: update imports
  • toolkit: tools.mk: update post refactor of internal -> pkg/
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
  • NA
Test Methodology
  • Local Build

  • Full Build: link

@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Mar 30, 2023
@mfrw mfrw requested a review from dmcilvaney March 30, 2023 05:58
@mfrw mfrw marked this pull request as ready for review March 30, 2023 06:10
@mfrw mfrw requested a review from a team as a code owner March 30, 2023 06:10
@mfrw mfrw added DevEx Developer Experience go Pull requests that update Go code Tools labels Mar 30, 2023
mfrw added 3 commits April 18, 2023 09:50
Signed-off-by: Muhammad Falak R Wani <[email protected]>
Signed-off-by: Muhammad Falak R Wani <[email protected]>
@mfrw mfrw force-pushed the mfrw/move-internal-to-pkg branch from 59acf7b to 4ca2c67 Compare April 18, 2023 04:42
@dmcilvaney
Copy link
Contributor

I'm open to this, although maybe we want to do this right after we snap for 3.0 just for a clean break?

@PawelWMS PawelWMS requested a review from a team as a code owner December 12, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevEx Developer Experience go Pull requests that update Go code main PR Destined for main Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants