Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the wrapper for linked domains validation which uses the injected root of trust resolver and fallback option. #122

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

nithyaganeshng
Copy link
Contributor

  • If injected root of trust resolver fails validating the linked domains, fallback option must be used. It is handled by the wrapper using which prevents duplicating the code.
  • This PR also includes unit tests for all the combinations of resolver and fallback option that need to be tested.

Validation:
Added unit tests for all the combinations of resolver and fallback option that need to be tested.

Type of change:

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk:

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Work Item links:
Please include here links for this work item, or deferred work, or related work. E.g. if the refactoring is too big to fit in this PR, or the localized strings need to be updated later, please link the TODO work items here.

Documentation Links:
Please include here links to any related background documentation for this PR.

…options linked domains could be validated with.
logangirvin
logangirvin previously approved these changes Jan 9, 2025
@nithyaganeshng nithyaganeshng merged commit 85fabea into dev Jan 9, 2025
1 check passed
@nithyaganeshng nithyaganeshng deleted the niganesh/unit-tests-for-linked-domains branch January 9, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants