docs(react-keytips): add detailed Overflow example #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainframev
force-pushed
the
docs/add-complete-example
branch
3 times, most recently
from
863ef0b to
442bba4
Compare
| disabled: false, | ||
| name: 'Feedback', | ||
| keytipProps: keytipsMap.feedback, | ||
| // icon: <NotepadPersonIcon />, |
There was a problem hiding this comment.
nit: probably, this comment is not needed
Suggested change
| // icon: <NotepadPersonIcon />, |
Comment on lines
6
to
12
| MenuButtonProps, | ||
| MenuList, | ||
| MenuItem, | ||
| MenuPopover, | ||
| MenuTrigger, | ||
| SplitButton, | ||
| SplitButtonProps, |
There was a problem hiding this comment.
Suggested change
| MenuButtonProps, | |
| MenuList, | |
| MenuItem, | |
| MenuPopover, | |
| MenuTrigger, | |
| SplitButton, | |
| SplitButtonProps, | |
| type MenuButtonProps, | |
| MenuList, | |
| MenuItem, | |
| MenuPopover, | |
| MenuTrigger, | |
| SplitButton, | |
| type SplitButtonProps, |
| icon={<MailRegular />} | ||
| menuButton={{ | ||
| ...triggerProps, | ||
| // @ts-expect-error TODO |
There was a problem hiding this comment.
Do you need TODO here?
| OverflowStory.parameters = { | ||
| docs: { | ||
| description: { | ||
| story: '', |
There was a problem hiding this comment.
Do you need this part if it's empty?
Comment on lines
3
to
10
| export const onExecute: ExecuteKeytipEventHandler = (_, { targetElement }) => { | ||
| if (targetElement) { | ||
| console.info(targetElement); | ||
| targetElement.focus(); | ||
| targetElement.click(); | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
Maybe it's better to move this method to some shared file, because it's duplicated in Home and Help folders.
ValentinaKozlova
approved these changes
Dec 27, 2024
mainframev
force-pushed
the
docs/add-complete-example
branch
from
f37a6b5 to
449020e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more detailed Overflow example, so it looks more closer to later usage by partners. Previous
Overflowexample renamed toShortcutas it mainly focuses on showing the shortcut behaviour.Screen.Recording.2024-12-19.at.15.58.58.mov