Add writability to vk::BufferPointer pointees #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add an example that shows the buffer being written to? |
@s-perron Done |
llvm-beanz
reviewed
Jun 26, 2023
| float4 MainPs(void) : SV_Target0 | ||
| { | ||
| float4 vTest = float4(1.0,0.0,0.0,0.0); | ||
| g_PushConstants.m_nBufferDeviceAddress.Get().g_vTestFloat4 = vTest; |
There was a problem hiding this comment.
Should we also include the expected SPIR-V operations for this code?
llvm-beanz
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41