-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM68] Add proposal for Work Graphs #62
Merged
pow2clk
merged 13 commits into
microsoft:main
from
llvm-beanz:cbieneman/sm68-work-graphs
Mar 29, 2024
Merged
[SM68] Add proposal for Work Graphs #62
pow2clk
merged 13 commits into
microsoft:main
from
llvm-beanz:cbieneman/sm68-work-graphs
Mar 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Work Graphs feature is a new approach to GPU work creation for HLSL on Shader Model 6.8. The feature extends library shaders to support node shaders which create work graphs. A preview implementation of this feature is available in the DXC 1.8.2306 preview release.
llvm-beanz
commented
Jun 25, 2023
This clarifies that attribute names should be case-insensitive, but attribute string arguments are case-sensitive.
llvm-beanz
commented
Jul 28, 2023
This updates the barrier definition with the new design. Partial fix for microsoft#101.
pow2clk
reviewed
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to cut out half way, but I wanted to give you something to think about and I have to go just now.
tex3d
requested changes
Mar 8, 2024
tex3d
reviewed
Mar 26, 2024
tex3d
reviewed
Mar 26, 2024
tex3d
reviewed
Mar 26, 2024
tex3d
reviewed
Mar 26, 2024
Co-authored-by: Tex Riddell <[email protected]>
Co-authored-by: Tex Riddell <[email protected]>
Added documentation for semantics numbered to 0018 in preparation for merging this shipping feature. Added documentation for SV_ semantics Fixed a few minor nitpicks and clarifications
reformat to comply with md best practices. Demoting the attributes from headers wasn't strictly necessary, but it solved a problem and I think the appearance is better and has less weird characters in what is ostensibly a linkable header. Reclarify a few things resulting from reviewing older suggestions and reformatting
tex3d
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
pow2clk
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Work Graphs feature is a new approach to GPU work creation for HLSL on Shader Model 6.8. The feature extends library shaders to support node shaders which create work graphs.
A preview implementation of this feature is available in the DXC 1.8.2306 preview release.
Fixes #101