-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update apache-tvm to v0.15.0 #709
Conversation
2309e06
to
77bc11e
Compare
TVM v0.12.0's pytorch frontend failes to import HB's pytorch model in v1.12.0. |
I did git bisect and found that the below commit has a problem. |
Seems like there's a bug in the PyTorch frontend. Opened new issue apache/tvm#16150. |
5a74e85
to
0204661
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #709 +/- ##
==========================================
- Coverage 90.11% 87.92% -2.20%
==========================================
Files 80 80
Lines 4685 4687 +2
Branches 857 857
==========================================
- Hits 4222 4121 -101
- Misses 266 368 +102
- Partials 197 198 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Was that last failure transient, or did something new break unrelated to TVM? Please let me know if you are blocked on something and I can try to help! |
dc15acd
to
1cf67c9
Compare
The CI test has passed but I don't know why... |
We'll wait for the TVM v0.15.0 which is going to be released on 22 Jan 2024. |
CI is failing again. Ok log: https://github.com/microsoft/hummingbird/actions/runs/7692350896/job/20959123441 |
Seems like tests are a bit flaky when TVM is installed from the cache. Only failed on ubuntu+python3.9: https://github.com/microsoft/hummingbird/actions/runs/7710611530/job/21014292656 @ksaur @interesaaat |
Hmmm, |
Note for the memory issue investigation
|
…u+GitHub Actions
Hi @mshr-h thanks for all your work on this!! (Especially thank you for the nice summary of the memory issue.) Is the PR still a WIP? I like the |
Should be good. @ksaur @interesaaat |
This looks good to me!! @interesaaat take a look and merge if ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for all your hard work! 🎊
TVM doesn't provide a stable version of a binary package for Python 3.11. So we'll build it from the source in the CI pipeline.
Also, we'll update TVM to the latest stable release.
Related to #643
TODO