-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
continue-on-error: true for mac tvm install fail #728
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #728 +/- ##
=======================================
Coverage 90.20% 90.20%
=======================================
Files 80 80
Lines 4676 4676
Branches 856 856
=======================================
Hits 4218 4218
Misses 260 260
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This does work, but now it fails silently. (The pipeline continues, runs all non-TVM tests on mac, and gives green checkmark without showing any warnings/etc.) This seems not a perfect solution either. There's probably some cleaner way to get alerts on this while not blocking everything. Thoughts Matteo/Masahiro? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Is this a draft or good to go? |
I just wanted both of your inputs to see if this is behavior we wanted. It may make things easier in future, but I also want to make sure mac TVM is supported when/where possible! |
Leaving this as a draft....ready to go if needed later (hopefully not). :) |
For #727