Use generic Promise return types #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ndiritu
force-pushed
the
fix/promises-generics
branch
from
797ca76 to
1c988e4
Compare
|
Pending release of microsoft/kiota-abstractions-php#99 |
Ndiritu
requested review from
ddyett,
MIchaelMainer,
nikithauc,
zengin,
SilasKenneth and
shemogumbe
as code owners
Ndiritu
force-pushed
the
fix/promises-generics
branch
from
ed56aa4 to
9ee53de
Compare
|
This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged. |
|
Kudos, SonarCloud Quality Gate passed! |
SilasKenneth
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to microsoft/kiota#3542