fix JSON.stringify for backed models

microsoft · Oct 16, 2023 · 66e0709 · 66e0709
1 parent 809a1a5
commit 66e0709
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 0 deletions.
diff --git a/packages/abstractions/src/store/backedModelProxy.ts b/packages/abstractions/src/store/backedModelProxy.ts
@@ -23,6 +23,8 @@ export function createBackedModelProxyHandler<T extends {}>(): ProxyHandler<T> {
         console.warn(`BackingStore - Ignoring attempt to set 'backingStore' property`);
         return true;
       }
+      // set the value on the target object as well to allow target object to have keys needed for serialization
+      Reflect.set(target, prop, value, receiver);
       console.debug(`BackingStore - Setting property '${prop.toString()}'`);
       backingStore.set(prop.toString(), value);
       return true;

diff --git a/packages/serialization/json/test/common/JsonParseNode.ts b/packages/serialization/json/test/common/JsonParseNode.ts
@@ -124,4 +124,42 @@ describe("JsonParseNode", () => {
     assert.equal(backingStore.get("testString"), "test");
   });
 
+  it("backing store shouldn't interfere with JSON.stringify", async () => {
+
+    const jsonObject = {
+      "foos": [
+          {
+            "id": "b089d1f1-e527-4b8a-ba96-094922af6e40",
+            "bars": [
+              {
+                "propA": "property A test value",
+                "propB": "property B test value"
+              }
+            ]
+          }
+      ]
+    };
+
+    const result = new JsonParseNode(jsonObject).getObjectValue(createTestBackedModelFromDiscriminatorValue) as TestBackedModel;
+    assert.equal(result.foos![0].bars![0].propA, "property A test value");
+    let jsonObjectStr = JSON.stringify(jsonObject);
+    let resultStr = JSON.stringify(result);
+    assert.equal(jsonObjectStr, resultStr);
+
+    // update the object then check stringify again
+    result.testString = "testStringValue";
+    jsonObjectStr = JSON.stringify(jsonObject);
+    resultStr = JSON.stringify(result);
+    assert.notEqual(jsonObjectStr, resultStr);
+
+    // update the backing store and check stringify again
+    const updateTestStrValue = "test string value";
+    const backingStore = result.backingStore;
+    backingStore.set("testString", updateTestStrValue);
+    const updatedJsonObject = {...jsonObject, testString: updateTestStrValue};
+    jsonObjectStr = JSON.stringify(updatedJsonObject);
+    resultStr = JSON.stringify(result);
+    assert.equal(jsonObjectStr, resultStr);
+  });
+
 });