Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the serialization/deserialization of composed types in typescript #1290

Merged
merged 6 commits into from
Sep 5, 2024

Conversation

koros
Copy link
Contributor

@koros koros commented Jul 24, 2024

Add unit tests to validate the logic in the serialization/deserialization of composed types

@koros koros requested a review from a team as a code owner July 24, 2024 13:16
andrueastman
andrueastman previously approved these changes Jul 25, 2024
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initiative! I think we should extend the test cases here.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@rkodev rkodev merged commit 33d4023 into main Sep 5, 2024
6 checks passed
@rkodev rkodev deleted the feature/validate-composed-types-logic branch September 5, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants