Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: disable default compression #1548

Merged
merged 1 commit into from
Jan 21, 2025
Merged

feat: disable default compression #1548

merged 1 commit into from
Jan 21, 2025

Conversation

rkodev
Copy link
Contributor

@rkodev rkodev commented Jan 14, 2025

Resolves #1439

Creates a separate pipeline for performance middleware to improve the performance of the HttpClient class. Removes copression from the default middleware chain and adds a new getPerformanceMiddlewares method to the MiddlewareFactory class.

@rkodev rkodev requested a review from a team as a code owner January 14, 2025 13:19
@rkodev rkodev marked this pull request as draft January 14, 2025 13:20
@rkodev rkodev force-pushed the feat/profile_compression branch from cd5e282 to 6815be0 Compare January 14, 2025 13:32
@rkodev rkodev force-pushed the feat/profile_compression branch from 6815be0 to cbf12ec Compare January 16, 2025 00:57
@rkodev rkodev force-pushed the feat/profile_compression branch from cbf12ec to 5b960f0 Compare January 16, 2025 01:06
@rkodev rkodev force-pushed the feat/profile_compression branch from 5b960f0 to a8fbe12 Compare January 16, 2025 01:17
@rkodev rkodev marked this pull request as ready for review January 16, 2025 01:20
baywet
baywet requested changes Jan 16, 2025
View reviewed changes
packages/http/fetch/src/httpClient.ts Outdated Show resolved Hide resolved
@baywet baywet mentioned this pull request Jan 16, 2025
Merged
@rkodev rkodev force-pushed the feat/profile_compression branch from a8fbe12 to 3e210c4 Compare January 20, 2025 07:42
@rkodev rkodev force-pushed the feat/profile_compression branch from 3e210c4 to 8ed62c2 Compare January 20, 2025 07:59
baywet
baywet approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@baywet baywet merged commit 72e7011 into main Jan 21, 2025
17 checks passed
@baywet baywet deleted the feat/profile_compression branch January 21, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Status: Done ✔️
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Garbled request body
2 participants
@rkodev @baywet