Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore backing store support #862

Merged
merged 15 commits into from
Oct 24, 2023
Merged

Restore backing store support #862

merged 15 commits into from
Oct 24, 2023

Conversation

koros
Copy link
Contributor

@koros koros commented Sep 26, 2023

This PR contains changes to add the backing store support for kiota-typescript generated code

@baywet baywet marked this pull request as draft September 26, 2023 13:20
@koros koros temporarily deployed to build_test October 4, 2023 14:33 — with GitHub Actions Inactive
@koros koros temporarily deployed to build_test October 4, 2023 14:33 — with GitHub Actions Inactive
@koros koros temporarily deployed to build_test October 12, 2023 12:17 — with GitHub Actions Inactive
@koros koros temporarily deployed to build_test October 12, 2023 12:17 — with GitHub Actions Inactive
@koros koros temporarily deployed to build_test October 16, 2023 08:48 — with GitHub Actions Inactive
@koros koros temporarily deployed to build_test October 16, 2023 08:48 — with GitHub Actions Inactive
@koros koros marked this pull request as ready for review October 16, 2023 09:06
@koros koros changed the title [Draft] restore backing store support Restore backing store support Oct 16, 2023
@koros koros temporarily deployed to build_test October 16, 2023 14:04 — with GitHub Actions Inactive
@koros koros temporarily deployed to build_test October 16, 2023 14:04 — with GitHub Actions Inactive
@koros koros temporarily deployed to build_test October 17, 2023 10:37 — with GitHub Actions Inactive
@koros koros temporarily deployed to build_test October 17, 2023 10:37 — with GitHub Actions Inactive
@koros koros temporarily deployed to build_test October 23, 2023 14:36 — with GitHub Actions Inactive
@koros koros temporarily deployed to build_test October 23, 2023 14:36 — with GitHub Actions Inactive
@koros koros temporarily deployed to build_test October 24, 2023 07:09 — with GitHub Actions Inactive
@koros koros temporarily deployed to build_test October 24, 2023 07:09 — with GitHub Actions Inactive
baywet
baywet approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the long haul here

@koros koros temporarily deployed to build_test October 24, 2023 12:54 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Generated "test-kiota-typescript-libraries" SDK package:

File count Size (Kb) Unpacked (Kb)
87747 10018.83 183339.16

@github-actions
Copy link
Contributor

Generated sample app bundle:

Stat Size (Kb) Parsed Size (Kb) Gzipped (Kb)
46429.64 11749.60 596.52

@koros koros merged commit 44a4071 into main Oct 24, 2023
7 checks passed
@koros koros deleted the feature/backing-store branch October 24, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@gavinbarron gavinbarron Awaiting requested review from gavinbarron

@andrueastman andrueastman Awaiting requested review from andrueastman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koros @baywet