Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add linux arm64 binaries #5970

Merged
merged 5 commits into from
Jan 9, 2025
Merged

ci: add linux arm64 binaries #5970

merged 5 commits into from
Jan 9, 2025

Conversation

calebkiage
Copy link
Contributor

closes #5817

@calebkiage calebkiage requested a review from a team as a code owner January 8, 2025 10:09
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking this on!
We also need a new entry in vscode/microsoft-kiota/package.json: runtimeDependencies so vscode installations on that arch/platform download this new variant.
Can you please also add a changelog entry?

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@calebkiage calebkiage mentioned this pull request Jan 8, 2025
@andreaTP
Copy link
Contributor

andreaTP commented Jan 8, 2025

After we have a first release, it would be lovely to verify that this works with asdf too:
https://github.com/asdf-community/asdf-kiota/blob/6b786a8db6bb0a6f0e07a0f8b018e13c66784941/lib/utils.bash#L61

@baywet
Copy link
Member

baywet commented Jan 8, 2025

After we have a first release, it would be lovely to verify that this works with asdf too: https://github.com/asdf-community/asdf-kiota/blob/6b786a8db6bb0a6f0e07a0f8b018e13c66784941/lib/utils.bash#L61

@andreaTP can you create an issue there to track that please?

@andreaTP
Copy link
Contributor

andreaTP commented Jan 8, 2025

Sure! Done: asdf-community/asdf-kiota#17

@andrueastman andrueastman enabled auto-merge January 9, 2025 11:51
@andrueastman andrueastman merged commit 8b04b37 into main Jan 9, 2025
213 checks passed
@andrueastman andrueastman deleted the chore/add-linux-arm64 branch January 9, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✔️
Development

Successfully merging this pull request may close these issues.

support linux aarch64
4 participants