Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Plugin generation #5986

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Fix: Plugin generation #5986

merged 5 commits into from
Jan 10, 2025
+18 −4

Conversation

thewahome
Copy link
Contributor

Overview

Closes #5978

Notes

The RPC server function to create plugins has a set number of arguments. Passing undefined for 'optional' arguments is interpreted as not having passed required arguments.

The changes included in this pull request update the GenerateClientCommand class in the generateClientCommand.ts file to use null instead of undefined for the optional argument.

@thewahome thewahome requested a review from a team as a code owner January 10, 2025 12:20
baywet
baywet approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the nature of the breakage, I think we need to release a patch version, I'll reach out internally to give you the information on how to do so.

baywet
baywet requested changes Jan 10, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry

@thewahome thewahome merged commit a7e254e into main Jan 10, 2025
243 checks passed
@thewahome thewahome deleted the fix/extension/failing-copilot-agent-generation branch January 10, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman andrueastman approved these changes

Assignees

@thewahome thewahome

Labels
None yet
Projects
Kiota
Status: Done ✔️
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kiota will throw unknown error when creating copilot plugin in VS Code extension
3 participants
@thewahome @andrueastman @baywet