update broadcast algo #447
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#417) Encountered a hang with rccl-test's ncclBcast runs. In rccl-test with ncclBcast, the buffer changes only for the root-gpu b/w test runs. So, the channel key changes only for the root gpu and remains the same for the other gpus. So, the root gpu starts to create a new sm channel while the other gpus do not create new sm channels. Hence, a hang occurs. To fix this, we have to use copy-based implementation. This is the simplest copy-based implementation. Uses a static channel key with sm channels created using scratch buffer as the remote memories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.