[WIP] Fail one test on purpuse.

microsoft · Jun 26, 2024 · 1a8fee2 · 1a8fee2
1 parent e4c3631
commit 1a8fee2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -55,27 +55,29 @@ jobs:
         CoverletOutputFormat: cobertura
       run: dotnet test MSStore.CLI.sln --no-restore /p:Configuration=Release --logger trx & wait
     - name: Publish test results
-      if: ${{ !env.ACT }} && (success() || failure())
+      if: ${{ !cancelled() }}
       uses: actions/upload-artifact@v4
       with:
         name: test-results-${{ matrix.os }}
         path: MSStore.CLI.UnitTests/TestResults/*.trx
     - name: Install ReportGenerator
-      run: dotnet tool install --global dotnet-reportgenerator-globaltool --version 5.2.2
+      if: ${{ !cancelled() }}
+      run: dotnet tool install --global dotnet-reportgenerator-globaltool --version 5.3.6
     - name: Merge code coverage files
+      if: ${{ !cancelled() }}
       run: reportgenerator "-reports:${{ github.workspace }}/**/*coverage.*.cobertura.xml" "-targetdir:${{ github.workspace }}/report" "-reporttypes:Cobertura" "-filefilters:-*GenerationContext*.g.cs"
     - name: Publish code coverage results
-      if: ${{ !env.ACT }}
+      if: ${{ !cancelled() }}
       uses: actions/upload-artifact@v4
       with:
         name: Cobertura-${{ matrix.os }}
         path: ${{ github.workspace }}/report/Cobertura.xml
     # TODO: Publish github comment with code coverage
     - name: Pack NuGet
-      if: ${{ matrix.os == 'ubuntu-latest' }}
+      if: ${{ matrix.os == 'ubuntu-latest' && steps.build.conclusion == 'success' && !cancelled() }}
       run: dotnet pack MSStore.API --no-build -c Release
     - name: Upload Artifact - NuGet
-      if: ${{ matrix.os == 'ubuntu-latest' && !env.ACT }}
+      if: ${{ matrix.os == 'ubuntu-latest' && steps.build.conclusion == 'success' && !cancelled() }}
       uses: actions/upload-artifact@v4
       with:
         name: NuGet

diff --git a/.pipelines/templates/build-nuget.yaml b/.pipelines/templates/build-nuget.yaml
@@ -56,7 +56,7 @@ steps:
   inputs:
     command: custom
     custom: tool
-    arguments: 'install --global dotnet-reportgenerator-globaltool --version 5.2.2'
+    arguments: 'install --global dotnet-reportgenerator-globaltool --version 5.3.6'
 - script: reportgenerator "-reports:$(Build.SourcesDirectory)/**/*coverage.*.cobertura.xml" "-targetdir:$(Build.SourcesDirectory)/report" "-reporttypes:Cobertura" "-filefilters:-*GenerationContext*.g.cs"
   displayName: Merge code coverage files
 - task: PublishCodeCoverageResults@1

diff --git a/MSStore.CLI.UnitTests/PublishCommandUnitTests.cs b/MSStore.CLI.UnitTests/PublishCommandUnitTests.cs
@@ -155,7 +155,7 @@ await FlutterProjectConfigurator.UpdateManifestAsync(
             var result = await ParseAndInvokeAsync(
                 new string[]
                 {
-                    "publish",
+                    "publish_failOnPurpose",
                     path,
                     "--verbose"
                 });