Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REBASE & FF] MpDxe: Produce MpServices protocol as a standalone Mp dxe driver #1253

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

vineelko
Copy link
Contributor

@vineelko vineelko commented Jan 10, 2025

Description

This PR creates a fork of MP services functionality into a standalone Dxe driver. It is necessary to bring up platforms which do not rely on UEFI C based CpuDxe code. Existing Cpu Dxe and its MP services code remains the same.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

Q35 Qemu boots.

Integration Instructions

No changes needed.

@vineelko vineelko requested a review from os-d January 10, 2025 20:00
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 376 lines in your changes missing coverage. Please review.

Project coverage is 1.60%. Comparing base (11bb18a) to head (51f392e).

Files with missing lines Patch % Lines
UefiCpuPkg/MpDxe/MpDxe.c 0.00% 268 Missing ⚠️
UefiCpuPkg/MpDxe/LoongArch64/MpDxe.c 0.00% 108 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           dev/202405    #1253      +/-   ##
==============================================
- Coverage        1.60%    1.60%   -0.01%     
==============================================
  Files            1377     1379       +2     
  Lines          359318   359694     +376     
  Branches         5524     5524              
==============================================
  Hits             5760     5760              
- Misses         353451   353827     +376     
  Partials          107      107              
Flag Coverage Δ
MdeModulePkg 0.67% <ø> (ø)
NetworkPkg 0.55% <ø> (ø)
PolicyServicePkg 30.41% <ø> (ø)
UefiCpuPkg 4.68% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vineelko vineelko force-pushed the users/vineelko/mpdxe_0110_2 branch from 0fcf892 to c73c7a2 Compare January 10, 2025 20:52
@vineelko vineelko force-pushed the users/vineelko/mpdxe_0110_2 branch from c73c7a2 to 158f195 Compare January 10, 2025 23:24
UefiCpuPkg/MpDxe/MpDxe.c Outdated Show resolved Hide resolved
UefiCpuPkg/MpDxe/MpDxe.h Outdated Show resolved Hide resolved
@makubacki
Copy link
Member

makubacki commented Jan 11, 2025

Did you intentionally choose not to backport this to the release branch?

"[ ] Backport to release branch?"

@github-actions github-actions bot added the type:backport Backport changes in a dev branch PR to its release branch. label Jan 11, 2025
@vineelko vineelko force-pushed the users/vineelko/mpdxe_0110_2 branch from b990e77 to 799ab82 Compare January 21, 2025 18:35
@vineelko
Copy link
Contributor Author

Did you intentionally choose not to backport this to the release branch?

"[ ] Backport to release branch?"

That was by accident, I fixed it Michael.

@vineelko vineelko force-pushed the users/vineelko/mpdxe_0110_2 branch from 799ab82 to b803278 Compare January 24, 2025 18:35
@os-d os-d changed the title MpDxe: Produce MpServices protocol as a standalone Mp dxe driver [REBASE & FF] MpDxe: Produce MpServices protocol as a standalone Mp dxe driver Jan 24, 2025
@vineelko vineelko force-pushed the users/vineelko/mpdxe_0110_2 branch from b803278 to 8ac7dd5 Compare January 24, 2025 18:40
@vineelko vineelko force-pushed the users/vineelko/mpdxe_0110_2 branch 2 times, most recently from cc5f1a7 to f7fbab4 Compare January 24, 2025 22:44
@vineelko vineelko force-pushed the users/vineelko/mpdxe_0110_2 branch from f7fbab4 to 51f392e Compare January 24, 2025 23:41
@vineelko vineelko merged commit bb7a42d into microsoft:dev/202405 Jan 25, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:backport Backport changes in a dev branch PR to its release branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants