Fix bug in function definition, deprecated core function params, and …

…comments
microsoft · Dec 7, 2023 · 58fe0dd · 58fe0dd
1 parent 6053ad7
commit 58fe0dd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/local/o365/classes/feature/calsync/main.php b/local/o365/classes/feature/calsync/main.php
@@ -127,8 +127,7 @@ public function ensure_event_synced_for_user($eventid, $muserid, $subject, $body
      * @param string $calid The o365 ID of the calendar to create the event in.
      * @return bool|int The new ID of the calidmap record.
      */
-    public function create_event_raw($muserid, $eventid, $subject, $body, $timestart, $timeend, $attendees, array $other = array(),
-        $calid) {
+    public function create_event_raw($muserid, $eventid, $subject, $body, $timestart, $timeend, $attendees, array $other, $calid) {
         global $DB;
         $apiclient = $this->construct_calendar_api($muserid, true);
         $o365upn = utils::get_o365_upn($muserid);

diff --git a/local/o365/classes/task/notifysecretexpiry.php b/local/o365/classes/task/notifysecretexpiry.php
@@ -45,7 +45,7 @@ public function get_name() {
     }
 
     /**
-     * Run the task to check on the expiry date of the secret, and send notiifation if needed.
+     * Run the task to check on the expiry date of the secret, and send notification if needed.
      *
      * @return bool
      */

diff --git a/local/onenote/classes/api/base.php b/local/onenote/classes/api/base.php
@@ -405,7 +405,7 @@ public function get_items_list($path = '') : array {
 
                     $items[] = ['title' => $itemname, 'path' => $path . '/' . urlencode($item['id']),
                         'date' => strtotime($itemlastmodified),
-                        'thumbnail' => $OUTPUT->image_url(file_extension_icon($itemname, 90))->out(false), 'source' => $item['id'],
+                        'thumbnail' => $OUTPUT->image_url(file_extension_icon($itemname))->out(false), 'source' => $item['id'],
                         'url' => $item['links']['oneNoteWebUrl']['href'], 'author' => $item['createdBy'], 'id' => $item['id'],
                         'children' => [],];
                     break;
@@ -422,7 +422,7 @@ public function get_items_list($path = '') : array {
 
                     $items[] = ['title' => $itemname, 'path' => $path . '/' . urlencode($item['id']),
                         'date' => strtotime($itemlastmodified),
-                        'thumbnail' => $OUTPUT->image_url(file_extension_icon($itemname, 90))->out(false), 'source' => $item['id'],
+                        'thumbnail' => $OUTPUT->image_url(file_extension_icon($itemname))->out(false), 'source' => $item['id'],
                         'url' => $item['self'], 'author' => $item['createdBy'], 'id' => $item['id'], 'children' => [],];
                     break;
 
@@ -434,7 +434,7 @@ public function get_items_list($path = '') : array {
 
                     $items[] = ['title' => $item['title'] . ".zip", 'path' => $path . '/' . urlencode($item['id']),
                         'date' => strtotime($itemcreatedtime),
-                        'thumbnail' => $OUTPUT->image_url(file_extension_icon($item['title'], 90))->out(false),
+                        'thumbnail' => $OUTPUT->image_url(file_extension_icon($item['title']))->out(false),
                         'source' => $item['id'], 'url' => $item['links']['oneNoteWebUrl']['href'],
                         'author' => $item['createdByAppId'], 'id' => $item['id'],];
                     break;
-Original file line number
+Diff line change
@@ Expand Up / @@ -45,7 +45,7 @@ public function get_name() { @@
         }
         /**
-         * Run the task to check on the expiry date of the secret, and send notiifation if needed.
+         * Run the task to check on the expiry date of the secret, and send notification if needed.
          *
          * @return bool
          */
@@ Expand Down @@