Configure NVMe keep-alive ability from host #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-oo
reviewed
Dec 16, 2024
| @@ -225,6 +225,11 @@ fn build_kernel_command_line( | |||
| )?; | |||
| } | |||
|
|
|||
| // Only when explicitly supported by Host. | |||
| if partition_info.nvme_keepalive && !partition_info.vtl2_pool_memory.is_empty() { | |||
There was a problem hiding this comment.
We should pass this via DT to usermode, the env args are for test/unstable features.
There was a problem hiding this comment.
Although if we want to keep it as unstable (env arg only), lets file a cleanup issue to track cleaning this up.
There was a problem hiding this comment.
okay, after your change I thought you wanted to keep it as command-line
There was a problem hiding this comment.
After further thinking I suggest to keep it as an env var for now and clanup later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inform OpenHCL that Host is compatible with NVMe keep-alive feature by adding a new device tree entry
/openhcl/vf-keepalive=nvmewhere vf-keepalive is a list of strings which may be expanded in future to include other device types such as
vf-keepalive=nvme,manaDuring servicing operation the host must now explicitly indicate that NVMe data should be saved (if VM supports it), this change flips the definition of keepalive bit in capabilities_flags bitmask (it used to be an emergency shut-off, not it is an "allow" indication). This flipping resolves compatibility issues with older host OSes after Live Migration.