vmbus_client: use existing mesh channels to send revoke #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarks
force-pushed
the
vmbus_client_cleanup_3
branch
from
9d1db38 to
65676df
Compare
SvenGroot
previously approved these changes
Jan 10, 2025
In the vmbus client, instead of sending a revoke over the general notify channel (which is hard to multiplex between multiple users of the vmbus client), notify a user of a revoke by closing the per-channel notification channel. This is the last non-offer use of the notify channel. Change the notify channel to just an offer channel.
jstarks
force-pushed
the
vmbus_client_cleanup_3
branch
from
65676df to
1d704cf
Compare
daprilik
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the vmbus client, instead of sending a revoke over the general notify channel (which is hard to multiplex between multiple users of the vmbus client), notify a user of a revoke by closing the per-channel notification channel.
This is the last non-offer use of the notify channel. Change the notify channel to just an offer channel.