Fix bug for running single flow nodes with nested dict inputs #3881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inputs like ${parent_node.output.result.inner_key} will fail because of how the inputs are currently written to the jsonl inputs file. Eg.
{"parent_node.output.result.inner_key":{"result":{"inner_key1":"foo","inner_key2":"bar"},"metrics":{"mertric_1":1.2}}
This is different behavior than when running entire flow where the input is always keyed on "parent_node.output.result" rather than "parent_node.output.result.inner_key".
add whitespace around operator
pjanowski
changed the title
|
Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. |
github-actions
bot
added
the
no-recent-activity
|
active |
github-actions
bot
removed
the
no-recent-activity
|
Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. |
github-actions
bot
added
the
no-recent-activity
|
@MilesHolland @ninghu @luigiw Can one of you review please? Has been submitted for review since 12/7/24. Thanks! |
github-actions
bot
removed
the
no-recent-activity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inputs like ${parent_node.output.result.inner_key} will fail because of how the inputs are currently written to the jsonl inputs file. Eg.
{"parent_node.output.result.inner_key":{"result":{"inner_key1":"foo","inner_key2":"bar"},"metrics":{"mertric_1":1.2}}
This is different behavior than when running entire flow where the input is always keyed on "parent_node.output.result" rather than "parent_node.output.result.inner_key".
All Promptflow Contribution checklist:
Fixes #3882
General Guidelines and Best Practices
Testing Guidelines