-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add extension_list example #279
add extension_list example #279
Conversation
add default data file
sync with the agent code
create a nuget spec
* Add pytest * Update pytest
the test needs to change into the right dotnet directory.
04e95e4
to
1db83ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for most part.
It looks like net40 is not being used. We should either lock it down with tests of remove it altogether if it is not needed.
@@ -19,8 +19,8 @@ jobs: | |||
|
|||
- name: Build | |||
run: dotnet build | |||
working-directory: ./bindings/csharp | |||
working-directory: ./bindings/csharp/net8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could test both net8.0 and net40
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try, but not sure if the tool chain can support both of them at the same time
@@ -0,0 +1,56 @@ | |||
using System; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add copyright notice in each file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do.
@@ -0,0 +1,122 @@ | |||
package agent_extension_policy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add copyright notice for each source file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do.
net40 is not tested because I am not sure if the tool chain can support net8.0 and net40 at the same time as net40 is pretty old but still needed by some applications. |
1db83ec
to
3d0012c
Compare
created an example of agent extension policy that is used for Azure agent extensions.
added support for .NET framework 4.0 binding.
added a pytest test for the policy using the python bindings (thus also tested python binding)
Reorganized the structure accordingly due to the above changes.