Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve anyhow compile errors #355

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

thedavemarshall
Copy link
Contributor

@anakrish while attempting to run the tests from main on a fresh development environment, I was getting several compiler warnings and errors. This intends to be the smallest change to get back to green.

  • add missing --features flag for aci rego-extensions and kata rego-extensions commands in scripts/pre-push
  • I'm not entirely clear on the traits for why ? wasn't playing well with anyhow, maybe it has something to do with default-features = false and no_std flag option? the fix seems to be map_err() calls
  • replace unnecessary lifetime references impl<'a> GoTimeFormatItems<'a> with impl GoTimeFormatItems<'_>, similar for impl Clone for Box<dyn '_ + Extension> {

These changes allow me to compile the project and run tests without error or warning output.

@anakrish
Copy link
Collaborator

anakrish commented Jan 6, 2025

@thedavemarshall Thanks for looking into this. This unblocks couple of PRs submited by depandabot.

Copy link
Collaborator

@anakrish anakrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anakrish anakrish merged commit ba3a128 into microsoft:main Jan 6, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants