Python: Improve azure assistant agent settings and retrieval operations. #10063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
Python Test Coverage Report •
Python Unit Test Overview
|
||||||||||||||||||||||||||||||
eavanvalkenburg
approved these changes
Jan 6, 2025
TaoChenOSU
approved these changes
Jan 6, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
…ns. (#10063) ### Motivation and Context The AzureAssistantAgent retrieval path was not handling the optional ad_token. The agent constructor was handling it, to a degree, but there were improvements to make and a helper function to introduce so that we remove some code duplication. <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description This PR: - Cleans up the code used to create the azure settings for an azure assistant agent by introducing a helper function to streamline the logic - Allows the AzureAssistantAgent.retrieve() method to use an ad_token, if desired. - Adds unit tests for the new logic. Other unit tests are still passing after the refactor. <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
eavanvalkenburg
approved these changes
Jan 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…P to include notes about VScode unit testing setup.
eavanvalkenburg
force-pushed
the
azure-agent-improvements
branch
from
31f3ef4 to
4ded537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The AzureAssistantAgent retrieval path was not handling the optional ad_token. The agent constructor was handling it, to a degree, but there were improvements to make and a helper function to introduce so that we remove some code duplication.
Description
This PR:
Contribution Checklist