add LoongArch aal

.github/workflows/main.yml

@@ -4,9 +4,9 @@ name: snmalloc CI
 on:
   # Triggers the workflow on push or pull request events but only for the master branch
   push:
-    branches: [ master ]
+    branches: [ main ]
   pull_request:
-    branches: [ master, snmalloc2 ]
+    branches: [ main, snmalloc1 ]
 
   # Allows you to run this workflow manually from the Actions tab
   workflow_dispatch:
@@ -18,39 +18,65 @@ jobs:
         # Build each combination of OS and release/debug variants
         os: [ "ubuntu-latest", "ubuntu-18.04", "macos-11", "macos-10.15", "freebsd-12.2", "freebsd-13.0" ]
         build-type: [ Release, Debug ]
-        extra-cmake-flags: [ " " ]
+        # Extra cmake flags.  GitHub Actions matrix overloads `include` to mean
+        # 'add extra things to a job' and 'add jobs'.  You can add extra things
+        # to a job by specifying things that exist in a job created from the
+        # matrix definition and adding things.  You can specify extra jobs by
+        # specifying properties that don't match existing jobs.  We use
+        # `cmake-flags` to add cmake flags to all jobs matching a pattern and
+        # `extra-cmake-flags` to specify a new job with custom CMake flags.
+        extra-cmake-flags: [ "" ]
         # Modify the complete matrix
         include:
           # Provide the dependency installation for each platform
           - os: "ubuntu-18.04"
             dependencies: "sudo apt install ninja-build"
+            cmake-flags: "-DSNMALLOC_USE_CXX17=ON"
           - os: "ubuntu-latest"
             dependencies: "sudo apt install ninja-build"
           - os: "macos-11"
-            dependencies: "brew update && brew install ninja"
+            # The homebrew packages are broken at the moment and error out
+            # after trying to install Python as a dependency of ninja because
+            # 2to3 exists.  As a quick hack, delete it first.  This should be
+            # removed once the homebrew install is fixed.
+            dependencies: "rm -f /usr/local/bin/2to3 ; brew update && brew install ninja"
           - os: "macos-10.15"
-            dependencies: "brew update && brew install ninja"
+            dependencies: "rm -f /usr/local/bin/2to3 ; brew update && brew install ninja"
           # Skip the tests for the FreeBSD release builds
+          # Also build-test the checked memcpy implementation while doing these.
+          # It is run-tested on Linux and should be the same everywhere.
           - os: "freebsd-13.0"
             build-type: Release
             build-only: yes
+            cmake-flags: "-DSNMALLOC_MEMCPY_BOUNDS=ON -DSNMALLOC_CHECK_LOADS=ON"
           - os: "freebsd-12.2"
             build-type: Debug
             build-only: yes
-          # Add the self-host build
-          - os: ubuntu-latest
+            cmake-flags: "-DSNMALLOC_MEMCPY_BOUNDS=ON -DSNMALLOC_CHECK_LOADS=ON"
+          # Add the self-host build, using the bounds-checked memcpy in
+          # maximally paranoid mode (checking loads and stores)
+          - os: "ubuntu-latest"
             build-type: Debug
             self-host: true
+            extra-cmake-flags: "-DSNMALLOC_MEMCPY_BOUNDS=ON -DSNMALLOC_CHECK_LOADS=ON"
+            dependencies: "sudo apt install ninja-build"
+          # Extra build to check using pthread library for destructing local state.
+          - os: "ubuntu-latest"
+            variant: "Ubuntu (with pthread destructors)."
+            dependencies: "sudo apt install ninja-build"
+            build-type: Debug
+            self-host: true
+            extra-cmake-flags: "-DSNMALLOC_USE_PTHREAD_DESTRUCTORS=On -DCMAKE_CXX_COMPILER=clang++-10 -DCMAKE_C_COMPILER=clang-10"
           # Add an extra element to the matrix that does a build with clang 12
           # but doesn't run tests.
           - os: "freebsd-13.0"
             variant: Clang 12 (Build only)
             extra-cmake-flags: "-DCMAKE_CXX_COMPILER=clang++12"
             build-only: yes
-          - os: ubuntu-latest
+          - os: "ubuntu-latest"
             variant: Clang 10 libstdc++ (Build only)
             dependencies: "sudo apt install ninja-build"
-            extra-cmake-flags: "-DCMAKE_CXX_COMPILER=clang++-10 -DCMAKE_CXX_FLAGS=-stdlib=libstdc++"
+            extra-cmake-flags: "-DCMAKE_CXX_COMPILER=clang++-10 -DCMAKE_C_COMPILER=clang-10 -DCMAKE_CXX_FLAGS=-stdlib=libstdc++"
             build-only: yes
       # Don't abort runners if a single one fails
       fail-fast: false
@@ -61,30 +87,58 @@ jobs:
     - name: Install build dependencies
       run: ${{ matrix.dependencies }}
     - name: Configure CMake
-      run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{matrix.build-type}} -G Ninja ${{ matrix.extra-cmake-flags }}
+      run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{matrix.build-type}} -G Ninja ${{ matrix.cmake-flags }} ${{ matrix.extra-cmake-flags }}
       # Build with a nice ninja status line
     - name: Build
       working-directory: ${{github.workspace}}/build
       run: NINJA_STATUS="%p [%f:%s/%t] %o/s, %es" ninja
     - name: Test file size of binaries is sane
       working-directory: ${{github.workspace}}/build
-      run: "ls -l func-first_operation-1 ; [ $(ls -l func-first_operation-1 | awk '{ print $5}') -lt 10000000 ]"
+      run: "ls -l func-first_operation-fast ; [ $(ls -l func-first_operation-fast | awk '{ print $5}') -lt 10000000 ]"
       # If the tests are enabled for this job, run them
     - name: Test
       if: ${{ matrix.build-only != 'yes' }}
       working-directory: ${{github.workspace}}/build
-      run: ctest --output-on-failure -j 4
+      run: ctest --output-on-failure -j 4 -C ${{ matrix.build-type }} --timeout 400
     - name: Selfhost
       if: ${{ matrix.self-host }}
       working-directory: ${{github.workspace}}/build
       run: |
-        sudo cp libsnmallocshim.so libsnmallocshim-16mib.so libsnmallocshim-oe.so /usr/local/lib/
+        sudo cp libsnmallocshim.so libsnmallocshim-checks.so /usr/local/lib/
         ninja clean
         LD_PRELOAD=/usr/local/lib/libsnmallocshim.so ninja
         ninja clean
-        LD_PRELOAD=/usr/local/lib/libsnmallocshim-16mib.so ninja
-        ninja clean
-        LD_PRELOAD=/usr/local/lib/libsnmallocshim-oe.so ninja
+        LD_PRELOAD=/usr/local/lib/libsnmallocshim-checks.so ninja
+
+  sanitizer:
+    strategy:
+      matrix:
+        # Build each combination of OS and release/debug variants
+        os: [ "ubuntu-latest"]
+        build-type: [ Release, Debug ]
+        include:
+          - os: "ubuntu-latest"
+            continue-on-error: # Don't class as an error if this fails, until we have a more reliablity.
+            variant: Clang 10 libc++ (TSan + UBSan)
+            dependencies: "sudo apt install ninja-build"
+            extra-cmake-flags: "-DCMAKE_CXX_COMPILER=clang++-10 -DCMAKE_CXX_FLAGS=-stdlib=\"libc++ -g\" -DSNMALLOC_SANITIZER=undefined,thread"
+      # Don't abort runners if a single one fails
+      fail-fast: false
+    runs-on: ${{ matrix.os }}
+    name: ${{ matrix.os }} ${{ matrix.build-type }} ${{ matrix.variant }}
+    steps:
+    - uses: actions/checkout@v2
+    - name: Install build dependencies
+      run: ${{ matrix.dependencies }}
+    - name: Configure CMake
+      run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{matrix.build-type}} -G Ninja ${{ matrix.cmake-flags }} ${{ matrix.extra-cmake-flags }}
+      # Build with a nice ninja status line
+    - name: Build
+      working-directory: ${{github.workspace}}/build
+      run: NINJA_STATUS="%p [%f:%s/%t] %o/s, %es" ninja
+    - name: Test
+      working-directory: ${{github.workspace}}/build
+      run: ctest --output-on-failure -j 4 -C ${{ matrix.build-type }} --timeout 400 -E "memcpy|external_pointer" --repeat-until-fail 2
 
   qemu-crossbuild:
     strategy:
@@ -95,18 +149,28 @@ jobs:
             system-processor: arm
             triple: arm-linux-gnueabihf
             rtld: ld-linux-armhf.so.3
+            ld-flavour: lld
           - name: arm64
             system-processor: aarch64
             triple: aarch64-linux-gnu
             rtld: ld-linux-aarch64.so.1
+            ld-flavour: lld
           - name: ppc64el
             system-processor: powerpc64le
             triple: powerpc64le-linux-gnu
             rtld: ld64.so.2
+            ld-flavour: lld
+          - name: riscv64
+            system-processor: riscv64
+            triple: riscv64-linux-gnu
+            rtld: ld-linux-riscv64-lp64d.so.1
+            extra-packages: binutils-riscv64-linux-gnu
+            ld-flavour: bfd
+            ld: /usr/bin/riscv64-linux-gnu-ld.bfd
       # Don't abort runners if a single one fails
       fail-fast: false
     runs-on: ubuntu-latest
-    name: Cross-build for ${{ matrix.arch.triple }}
+    name: ${{matrix.build-type}} cross-build for ${{ matrix.arch.triple }}
     steps:
     - uses: actions/checkout@v2
     - name: Install cross-compile toolchain and QEMU
@@ -117,6 +181,14 @@ jobs:
         sudo add-apt-repository "deb http://apt.llvm.org/focal/     llvm-toolchain-focal-13  main"
         sudo apt update
         sudo apt install libstdc++-9-dev-${{ matrix.arch.name }}-cross qemu-user ninja-build clang-13 lld-13
+        sudo apt install ${{matrix.arch.extra-packages}}
+        # The default PowerPC qemu configuration uses the wrong page size.
+        # Wrap it in a script that fixes this.
+        sudo update-binfmts --disable qemu-ppc64le
+        sudo sh -c 'echo ":qemu-ppc64le:M:0:\x7f\x45\x4c\x46\x02\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x15\x00:\xff\xff\xff\xff\xff\xff\xff\xfc\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\x00:`pwd`/ppc64.sh:" > /proc/sys/fs/binfmt_misc/register'
+        echo '#!/bin/sh' > ppc64.sh
+        echo '/usr/bin/qemu-ppc64le -p 65536 $@' >> ppc64.sh
+        chmod +x ppc64.sh
     - name: Configure
       run: >
         RTLD_NAME=${{ matrix.arch.rtld }}
@@ -130,6 +202,8 @@ jobs:
         -DSNMALLOC_QEMU_WORKAROUND=ON
         -DSNMALLOC_STATIC_LIBRARY=OFF
         -DCMAKE_TOOLCHAIN_FILE=ci/Toolchain.cmake
+        -DSNMALLOC_LINKER=${{matrix.arch.ld}}
+        -DSNMALLOC_LINKER_FLAVOUR=${{matrix.arch.ld-flavour}}
     - name: Build
       working-directory: ${{github.workspace}}/build
       run: NINJA_STATUS="%p [%f:%s/%t] %o/s, %es" ninja
@@ -138,31 +212,43 @@ jobs:
     # QEMU)
     - name: Test
       working-directory: ${{github.workspace}}/build
-      run: ctest --output-on-failure -E '(perf-.*)|(.*-malloc$)'
+      run: ctest --output-on-failure -E '(perf-.*)|(.*-malloc$)' --timeout 400
       timeout-minutes: 30
 
   windows:
     strategy:
       matrix:
         # Build each combination of OS and release/debug variants
-        os: [ windows-2016, windows-2019 ]
+        os: [ windows-2019 ]
         build-type: [ Release, Debug ]
         arch: [ Win32, x64 ]
         toolchain: [ "", "-T ClangCL" ]
         extra-cmake-flags: [ "" ]
-        # The ClangCL toolchain was added in Visual Studio 2019, the Windows
-        # 2016 runners have only VS 2017, so skip them for this configuration
-        exclude:
-          - os: windows-2016
-            toolchain: "-T ClangCL"
         # Add an extra check for the Windows 8 compatible PAL
         include:
-          - os: windows-2016
+          - os: windows-2019
             build-type: Release
             arch: x64
             toolchain: ""
             extra-cmake-flags: -DWIN8COMPAT=TRUE
             variant: Windows 8 compatible
+          - os: windows-2022
+            build-type: Release
+            arch: Win32
+            toolchain: ""
+          - os: windows-2022
+            build-type: Debug
+            arch: Win32
+            toolchain: ""
+          - os: windows-2022
+            build-type: Release
+            arch: x64
+            toolchain: ""
+          - os: windows-2022
+            build-type: Debug
+            arch: x64
+            toolchain: ""
+
       # Don't abort runners if a single one fails
       fail-fast: false
     runs-on: ${{ matrix.os }}
@@ -178,7 +264,8 @@ jobs:
       # Run the tests.
     - name: Test
       working-directory: ${{ github.workspace }}/build
-      run: ctest -j 2 --interactive-debug-mode 0 --output-on-failure -C ${{ matrix.build-type }}
+      run: ctest -j 2 --interactive-debug-mode 0 --output-on-failure -C ${{ matrix.build-type }} --timeout 400
+      timeout-minutes: 20
 
 
   # Job to run clang-format and report errors
@@ -188,7 +275,7 @@ jobs:
     steps:
     - uses: actions/checkout@v2
     - name: Configure CMake
-      run: cmake -B ${{github.workspace}}/build
+      run: cmake -B ${{github.workspace}}/build -DSNMALLOC_USE_CXX17=ON
     - name: Install clang-tidy
       run: sudo apt install clang-tidy-9
     # Run the clang-format check and error if it generates a diff
@@ -200,7 +287,7 @@ jobs:
         git diff --exit-code
     - name: Run clang-tidy
       run: |
-        clang-tidy-9  src/override/malloc.cc  -header-filter="`pwd`/*" -warnings-as-errors='*' -export-fixes=tidy.fail -- -std=c++17 -mcx16 -DSNMALLOC_PLATFORM_HAS_GETENTROPY=0
+        clang-tidy-9  src/snmalloc/override/malloc.cc  -header-filter="`pwd`/*" -warnings-as-errors='*' -export-fixes=tidy.fail -- -std=c++17 -mcx16 -DSNMALLOC_PLATFORM_HAS_GETENTROPY=0
         if [ -f tidy.fail ] ; then
           cat tidy.fail
           exit 1

.github/workflows/morello.yml

@@ -0,0 +1,93 @@
+name: snmalloc CI for Morello
+
+# Controls when the workflow will run
+on:
+  # Triggers the workflow on push or pull request events but only for the master branch
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ main ]
+
+  # Allows you to run this workflow manually from the Actions tab
+  workflow_dispatch:
+
+jobs:
+  # UNIX-like, but with some needed TLC for the moment, so not folded in to the main unixlike CI.
+  # Morello can't easily self-host since it mixes purecap and hybrid build tools.
+  # We point cmake at the LLVM Clang frontend explicitly lest it pick up the more magic wrappers.
+  morello:
+    strategy:
+      matrix:
+        # Build each combination of OS and release/debug variants
+        os: [ "morello" ]
+        build-type: [ Release, Debug ]
+        caps: [ Hybrid, Purecap ]
+        include:
+          - os: "morello"
+            caps: Hybrid
+            dependencies: |
+              pkg64 install -y llvm-localbase cmake ninja
+            cmake-flags: >
+              -DCMAKE_CXX_COMPILER=/usr/local64/bin/clang++
+              -DCMAKE_C_COMPILER=/usr/local64/bin/clang
+              -DCMAKE_CXX_FLAGS='-march=morello -Xclang -morello-vararg=new'
+              -DCMAKE_C_FLAGS='-march=morello -Xclang -morello-vararg=new'
+          - os: "morello"
+            caps: Purecap
+            dependencies: |
+              pkg64 install -y llvm-localbase cmake ninja
+            cmake-flags: >
+              -DCMAKE_CXX_COMPILER=/usr/local64/bin/clang++
+              -DCMAKE_C_COMPILER=/usr/local64/bin/clang
+              -DCMAKE_CXX_FLAGS='-march=morello -mabi=purecap -Xclang -morello-vararg=new'
+              -DCMAKE_C_FLAGS='-march=morello -mabi=purecap -Xclang -morello-vararg=new'
+              -DSNMALLOC_LINK_ICF=OFF
+            # SNMALLOC_LINK_ICF=OFF until the fix for
+            # https://git.morello-project.org/morello/llvm-project/-/issues/51 , namely
+            # https://git.morello-project.org/morello/llvm-project/-/commit/f41cb9104e0793de87d98b38acb274b2e3266091
+            # lands in a package or a release.  That's probably the Fall 2022 release.
+      # Don't abort runners if a single one fails
+      fail-fast: false
+    # Morello needs special handling to get picked up by our self-hosted runners
+    # When/if we do integrate this back into the unixlike matrix above, we could
+    # say something like::
+    #   runs-on: >-
+    #     ${{ (matrix.os == 'morello' && fromJSON('["self-hosted", "msr-morello", "2022.05-benchmark"]'))
+    #         || matrix.os }}
+    # to dispatch dynamically.
+    runs-on: ["self-hosted", "msr-morello", "2022.05-benchmark"]
+    name: ${{ matrix.os }} ${{ matrix.build-type }} ${{ matrix.caps }}
+    steps:
+    - uses: actions/checkout@v2
+    - name: Install build dependencies
+      run: ${{ matrix.dependencies }}
+    - name: Configure CMake
+      run: >
+        cmake
+        -B ${{github.workspace}}/build
+        -DCMAKE_BUILD_TYPE=${{matrix.build-type}}
+        -G Ninja ${{ matrix.cmake-flags }}
+        ${{ matrix.extra-cmake-flags }}
+      # Build with a nice ninja status line
+    - name: Build
+      # https://github.com/ChristopherHX/github-act-runner seemingly ignores working-directory,
+      # but everyone agrees that we start in ${{github.workspace}} by default, so just cd into
+      # the build directory ourselves.  See
+      #   https://docs.github.com/en/actions/learn-github-actions/contexts#github-context
+      #   https://github.com/ChristopherHX/github-act-runner/issues/61
+      # working-directory: ${{github.workspace}}/build
+      run: |
+        cd build
+        NINJA_STATUS="%p [%f:%s/%t] %o/s, %es" ninja
+    - name: Test file size of binaries is sane
+      # working-directory: ${{github.workspace}}/build
+      run: |
+        cd build
+        ls -l func-first_operation-fast ; [ $(ls -l func-first_operation-fast | awk '{ print $5}') -lt 10000000 ]
+      # If the tests are enabled for this job, run them
+    - name: Test
+      if: ${{ matrix.build-only != 'yes' }}
+      # working-directory: ${{github.workspace}}/build
+      run: |
+        cd build
+        ctest --output-on-failure -j 4 -C ${{ matrix.build-type }} --timeout 400

.gitignore

@@ -1,8 +1,20 @@
+# conventional build dirs
 release*/
 debug*/
 build*/
+cmake-build-*/
+
+# cmake intermediate files
 CMakeFiles/
+
+# vscode dirs
 .vscode/
 .vs/
+
+# jetbrains IDE dirs
+.idea/
+
+# special endings
 *~
 *.sw?
+