issue diagnostic for a templated model with a template parameter that is not used. #5494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunyu3
requested review from
RodgeFu,
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
microsoft-github-policy-service
bot
added
the
compiler:core
chunyu3
added
ide
|
You can try these changes here
|
markcowl
reviewed
Jan 9, 2025
| "unused-template-parameter": { | ||
| severity: "hint", | ||
| messages: { | ||
| default: paramMessage`Template may only specify used parameter, and '${"parameterName"}' does not exist in type '${"type"}'.`, |
There was a problem hiding this comment.
Suggested change
| default: paramMessage`Template may only specify used parameter, and '${"parameterName"}' does not exist in type '${"type"}'.`, | |
| default: paramMessage`Templates should use all specified parameters, and parameter '${"parameterName"}' does not exist in type '${"type"}'. Consider removing this parameter.`, |
| @@ -135,6 +135,7 @@ alias integral = int32 | int64 | uint32 | uint64 | boolean; | |||
| * @template Key the key type (any integral type or string) | |||
| * @template Value the value type (any type other than another map) | |||
| */ | |||
| #suppress "unused-template-parameter" | |||
There was a problem hiding this comment.
Do we need a suppression here if this is not a warning? What is the impact of an unsuppressed hint diagnostic on compilation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #181
Fix #5488