Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libideviceactivation] Add tools feature #33871

Merged
merged 4 commits into from
Sep 22, 2023
Merged

[libideviceactivation] Add tools feature #33871

merged 4 commits into from
Sep 22, 2023

Conversation

xiaozhuai
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

See also #33246

@xiaozhuai xiaozhuai mentioned this pull request Sep 19, 2023
Merged
17 tasks
@Adela0814 Adela0814 requested review from vicroms and removed request for vicroms September 20, 2023 02:20
@jimwang118 jimwang118 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 20, 2023
@jimwang118
Copy link
Contributor

All features passed with following triplets:

x64-windows
x64-windows-static

Usage test pass with following triplets:

x64-windows
x64-windows-static

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Sep 21, 2023
@vicroms vicroms merged commit c96d040 into microsoft:master Sep 22, 2023
@xiaozhuai xiaozhuai deleted the dev-libideviceactivation branch September 25, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jimwang118 jimwang118

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaozhuai @jimwang118 @vicroms