fix: enhance error handling in ProfilesTreeItem (#303)

* enhance error handling in ProfilesTreeItem * added tests --------- Co-authored-by: Alex Yang <[email protected]>
microsoft · Jan 9, 2025 · 8060199 · 8060199
1 parent 18aa2f8
commit 8060199
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -24,7 +24,7 @@ Follow the official documents to install the required softwares:
 ### Build the project
 
 1. Clone this repo locally. (`git clone https://github.com/Microsoft/vscode-azureapicenter.git`)
-1. Open a terminal and build locally. (`npm install && npm run package`)
+1. Open a terminal and build locally. (`npm install && npm run watch`)
 
 ### Debug the project
 

diff --git a/src/test/unit/tree/rules/ProfilesTreeItem.test.ts b/src/test/unit/tree/rules/ProfilesTreeItem.test.ts
@@ -60,4 +60,14 @@ describe('ProfilesTreeItem', () => {
     it('should indicate no more children', () => {
         assert.strictEqual(profilesTreeItem.hasMoreChildrenImpl(), false);
     });
+
+    it('should handle no analysis configs gracefully', async () => {
+        const apiCenterServiceStub = sandbox.stub(ApiCenterService.prototype, 'getApiCenterAnalyzerConfigs').resolves({ value: [] });
+        sandbox.stub(profilesTreeItem, 'createTreeItemsWithErrorHandling').resolves([]);
+
+        const children = await profilesTreeItem.loadMoreChildrenImpl(false, <IActionContext>{});
+
+        assert(apiCenterServiceStub.calledOnce);
+        assert.strictEqual(children.length, 0);
+    });
 });
diff --git a/src/tree/rules/ProfilesTreeItem.ts b/src/tree/rules/ProfilesTreeItem.ts
@@ -28,7 +28,8 @@ export class ProfilesTreeItem extends AzExtParentTreeItem {
         const resourceGroupName = getResourceGroupFromId(this.apiCenter.id);
         const apiCenterService = new ApiCenterService(this.parent?.subscription!, resourceGroupName, this.apiCenter.name);
 
-        const analyzerConfigs = (await apiCenterService.getApiCenterAnalyzerConfigs()).value;
+        // Fetch analyzer configurations, default to an empty array if none are found
+        const analyzerConfigs = (await apiCenterService.getApiCenterAnalyzerConfigs())?.value || [];
 
         return await this.createTreeItemsWithErrorHandling(
             analyzerConfigs,